{{ message }}
Added length unit conversions - #5373
Merged
Merged
Conversation
Conversion of length units were added with respective tests being implemented and passed. Available Units:- Metre,Kilometre,Feet,Inch,Centimeter,Yard,Foot,Mile,Millimeter
ghost
added
awaiting reviews
File was formatted to go as per repo rules
Contributor
Author
Contributor
Author
|
@cclauss The tests have been passed. Let me know if I can do anymore changes/contribution !! |
l3str4nge
reviewed
Oct 18, 2021
ghost
added
awaiting changes
ghost
added
awaiting reviews
Added test to evaluate whether the code handles wrong arguements passed
Contributor
Author
|
The tests are passing in my Pycharm with doctests().But why is it failing here in pre-commit ? It initially passed too before this change!! Any reason why ? |
Member
|
conversions/length_conversions.py:106:89: E501 line too long (96 > 88 characters) |
One of the test was failing and it was fixed
Contributor
Author
cclauss
approved these changes
Oct 19, 2021
cclauss
left a comment
cclauss
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for the cleanup. I was trying to fix things in Pythonista on my iPad (imperfect ;-) )and was just switching to my MacBook when I saw that you already cleaned things up.
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
* Added length unit conversions Conversion of length units were added with respective tests being implemented and passed. Available Units:- Metre,Kilometre,Feet,Inch,Centimeter,Yard,Foot,Mile,Millimeter * Formatted File File was formatted to go as per repo rules * Reformatted file * Reformatted code once again * Added more test Added test to evaluate whether the code handles wrong arguements passed * Update length_conversions.py * Update length_conversions.py * Update length_conversions.py * Update length_conversions.py * Update length_conversions.py * Update length_conversions.py * Update length_conversions.py * Fixed Minor errors in test One of the test was failing and it was fixed Co-authored-by: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conversion of length units were added with respective tests being implemented and passed.
Available Units:- Metre,Kilometre,Feet,Inch,Centimeter,Yard,Foot,Mile,Millimeter
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.