Add tests to morse_code.py by cclauss · Pull Request #5337 · TheAlgorithms/Python · GitHub
Skip to content

Add tests to morse_code.py - #5337

Merged
cclauss merged 2 commits into
masterfrom
Add-tests-to-morse_code.py
Oct 16, 2021
Merged

Add tests to morse_code.py#5337
cclauss merged 2 commits into
masterfrom
Add-tests-to-morse_code.py

Conversation

@cclauss

@cclauss cclauss commented Oct 16, 2021

Copy link
Copy Markdown
Member

@dhruvmanila @poyea Your reviews, please.

Describe your change:

  • Add tests to an existing algorithm?
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss
cclauss requested review from dhruvmanila and poyea October 16, 2021 07:56
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 16, 2021
poyea
poyea reviewed Oct 16, 2021
View reviewed changes
Comment thread ciphers/morse_code.py
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 16, 2021
@cclauss
cclauss merged commit 8dc7cdb into master Oct 16, 2021
@cclauss
cclauss deleted the Add-tests-to-morse_code.py branch October 16, 2021 16:57
@cclauss

cclauss commented Oct 16, 2021

Copy link
Copy Markdown
Member Author

shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@cclauss github-actions @shermanhui
Add tests to morse_code.py (TheAlgorithms#5337)
82e5459 
* Add tests to morse_code.py

@dhruvmanila @poyea Your reviews, please.

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea approved these changes
@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cclauss @poyea