Add Proth number to maths by jrinder42 · Pull Request #5246 · TheAlgorithms/Python · GitHub
Skip to content

Add Proth number to maths - #5246

Merged
cclauss merged 4 commits into
TheAlgorithms:masterfrom
jrinder42:proth-number
Oct 14, 2021
Merged

Add Proth number to maths#5246
cclauss merged 4 commits into
TheAlgorithms:masterfrom
jrinder42:proth-number

Conversation

@jrinder42

@jrinder42 jrinder42 commented Oct 11, 2021

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@jrinder42
jrinder42 requested a review from Kush1101 as a code owner October 11, 2021 16:58
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Oct 11, 2021
cclauss
cclauss reviewed Oct 11, 2021
View reviewed changes
Comment thread maths/proth_number.py
cclauss
cclauss reviewed Oct 11, 2021
View reviewed changes
Comment thread maths/proth_number.py Outdated
@ghost ghost added the tests are failing Do not merge until tests pass label Oct 11, 2021
cclauss
cclauss reviewed Oct 11, 2021
View reviewed changes
Comment thread maths/proth_number.py Outdated
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 11, 2021
@jrinder42
jrinder42 requested a review from cclauss October 13, 2021 17:02
cclauss
cclauss approved these changes Oct 14, 2021
View reviewed changes

@cclauss cclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 14, 2021
@cclauss
cclauss merged commit 618f9ca into TheAlgorithms:master Oct 14, 2021
@jrinder42
jrinder42 deleted the proth-number branch October 14, 2021 20:55
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@jrinder42 @cclauss @shermanhui
Add Proth number to maths (TheAlgorithms#5246)
4896a27 
* Add Proth number to maths

* Add test for 0 and more informative output

* Fixing test failure issue - unused variable

* Update proth_number.py

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes
@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jrinder42 @cclauss