added Schur complement to linear algebra by iradonov · Pull Request #4793 · TheAlgorithms/Python · GitHub
Skip to content

added Schur complement to linear algebra - #4793

Merged
l3str4nge merged 5 commits into
TheAlgorithms:masterfrom
iradonov:feature/schur_complement
Oct 18, 2021
Merged

added Schur complement to linear algebra#4793
l3str4nge merged 5 commits into
TheAlgorithms:masterfrom
iradonov:feature/schur_complement

Conversation

@iradonov

@iradonov iradonov commented Sep 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added require descriptive names This PR needs descriptive function and/or variable names require type hints https://docs.python.org/3/library/typing.html labels Sep 27, 2021
ghost
ghost reviewed Sep 27, 2021
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment thread linear_algebra/src/schur_complement.py Outdated
Comment thread linear_algebra/src/schur_complement.py Outdated
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Sep 27, 2021
@ghost ghost removed require descriptive names This PR needs descriptive function and/or variable names require type hints https://docs.python.org/3/library/typing.html labels Sep 27, 2021
l3str4nge
l3str4nge requested changes Sep 29, 2021
View reviewed changes
Comment thread linear_algebra/src/schur_complement.py

@l3str4nge l3str4nge Sep 29, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests for this condition.

@iradonov iradonov Oct 13, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l3str4nge added tests.

Comment thread linear_algebra/src/schur_complement.py
Instead found A of size {shape_a} and B of size {shape_b}"
)

if shape_b[1] != shape_c[1]:

@l3str4nge l3str4nge Sep 29, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests for this condition.

@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Sep 29, 2021
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Sep 30, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Oct 13, 2021
@l3str4nge

l3str4nge commented Oct 13, 2021

Copy link
Copy Markdown
Member

Please fix the tests

@iradonov

iradonov commented Oct 18, 2021

Copy link
Copy Markdown
Contributor Author

@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 18, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 18, 2021
@l3str4nge
l3str4nge merged commit 4af5215 into TheAlgorithms:master Oct 18, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@iradonov Ivan Radonov @shermanhui
added Schur complement to linear algebra (TheAlgorithms#4793)
4682a63 
* added schur complement and tests to linear algebra

* updated according to checklist

* updated variable names and typing

* added two testcases for input validation

* fixed import order

Co-authored-by: Ivan Radonov <ivan.radonov@ad.mentormate.bg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iradonov @l3str4nge