{{ message }}
Physics new code - #4709
Merged
Merged
Physics new code#4709
Conversation
ghost
reviewed
Sep 3, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
ghost
added
the 
And also changed output to math notation
QuantumNovice
suggested changes
Sep 5, 2021
Contributor
|
One last request. Good Work.👍 👍 👍 |
Contributor
Author
Done. Thank You. |
Contributor
|
@cclauss have a look at this. |
|
It is working |
cclauss
reviewed
Sep 6, 2021
cclauss
reviewed
Sep 6, 2021
cclauss
reviewed
Sep 6, 2021
And comments
cclauss
reviewed
Sep 6, 2021
Replicate the exceptions of https://docs.python.org/3/library/math.html#math.gamma
cclauss
approved these changes
Sep 6, 2021
Member
There was a problem hiding this comment.
Nice work. I modified the exceptions to more closely mimic the Python's Standard Library math.gamma() function.
Dummy59
suggested changes
Sep 10, 2021
Member
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
* added gamma_function * Add files via upload * Resolved issue with str.format And also changed output to math notation * Update gamma_function.py * Rename physics/gamma_function.py to maths/gamma_recursive.py * Fixes: TheAlgorithms#4709 Fixed issues for pre-commit test * Fixes: TheAlgorithms#4709 solved issues with doctests And comments * Fixes: TheAlgorithms#4709 Added failed tests to doctest * Align with Python's Standard Library math.gamma() Replicate the exceptions of https://docs.python.org/3/library/math.html#math.gamma * Update gamma_recursive.py * Update gamma_recursive.py * Update gamma_recursive.py * Update gamma_recursive.py Co-authored-by: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Added new file to Physics folder. This file contain a function to calculate gamma function which is a common tool used in physics.
Checklist:
Fixes: #{$ISSUE_NO}.