iframe-proxy

srkchowdary2000 · 2021-08-21T12:51:45Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-08-21T12:51:49Z

+
+class Graph:
+    """Class Graph."""
+    def __init__(self, num_of_nodes):


Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: num_of_nodes

ghost · 2021-08-21T12:51:49Z

+        self.m_edges = []
+        self.m_component = {}
+
+    def add_edge(self, u, v, weight):


Please provide return type hint for the function: add_edge. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: u

Please provide descriptive name for the parameter: u

Please provide type hint for the parameter: v

Please provide descriptive name for the parameter: v

Please provide type hint for the parameter: weight

ghost · 2021-08-21T12:51:49Z

+
+        self.m_edges.append([u, v, weight])
+
+    def find_component(self, u):


Please provide return type hint for the function: find_component. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: u

Please provide descriptive name for the parameter: u

ghost · 2021-08-21T12:51:49Z

+            return u
+        return self.find_component(self.m_component[u])
+
+    def set_component(self, u):


Please provide return type hint for the function: set_component. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: u

Please provide descriptive name for the parameter: u

ghost · 2021-08-21T12:51:49Z

+            for k in self.m_component.keys():
+                self.m_component[k] = self.find_component(k)
+
+    def union(self, component_size, u, v):


Please provide return type hint for the function: union. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: component_size

Please provide type hint for the parameter: u

Please provide descriptive name for the parameter: u

Please provide type hint for the parameter: v

Please provide descriptive name for the parameter: v

ghost · 2021-08-21T12:51:50Z

+
+        print(self.m_component)
+
+    def boruvka(self):


Please provide return type hint for the function: boruvka. If the function does not return a value, please provide the type hint as: def function() -> None:

…panning tree.

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-08-21T12:58:39Z

+class Graph:
+    """Class Graph."""
+
+    def __init__(self, num_of_nodes) -> None:


Please provide type hint for the parameter: num_of_nodes

ghost · 2021-08-21T12:58:39Z

+        self.m_edges = []
+        self.m_component = {}
+
+    def add_edge(self, u, v, weight) -> None:


Please provide type hint for the parameter: u

Please provide descriptive name for the parameter: u

Please provide type hint for the parameter: v

Please provide descriptive name for the parameter: v

Please provide type hint for the parameter: weight

ghost · 2021-08-21T12:58:39Z

+
+        self.m_edges.append([u, v, weight])
+
+    def find_component(self, u) -> int:


Please provide type hint for the parameter: u

Please provide descriptive name for the parameter: u

ghost · 2021-08-21T12:58:39Z

+            return u
+        return self.find_component(self.m_component[u])
+
+    def set_component(self, u) -> None:


Please provide type hint for the parameter: u

Please provide descriptive name for the parameter: u

ghost · 2021-08-21T12:58:39Z

+            for k in self.m_component.keys():
+                self.m_component[k] = self.find_component(k)
+
+    def union(self, component_size, u, v) -> None:


Please provide type hint for the parameter: component_size

Please provide type hint for the parameter: u

Please provide descriptive name for the parameter: u

Please provide type hint for the parameter: v

Please provide descriptive name for the parameter: v

srkchowdary2000

Added Borůvka's algorithm, a graph algorithm that finds the minimum spanning tree.

…panning tree.

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-08-21T13:04:31Z

+        self.m_edges = []
+        self.m_component = {}
+
+    def add_edge(self, u: int, v: int, weight: int) -> None:


Please provide descriptive name for the parameter: u

Please provide descriptive name for the parameter: v

ghost · 2021-08-21T13:04:31Z

+
+        self.m_edges.append([u, v, weight])
+
+    def find_component(self, u: int) -> int:


Please provide descriptive name for the parameter: u

ghost · 2021-08-21T13:04:32Z

+            return u
+        return self.find_component(self.m_component[u])
+
+    def set_component(self, u: int) -> None:


Please provide descriptive name for the parameter: u

ghost · 2021-08-21T13:04:32Z

+            for k in self.m_component.keys():
+                self.m_component[k] = self.find_component(k)
+
+    def union(self, component_size: list, u: int, v: int) -> None:


Please provide descriptive name for the parameter: u

Please provide descriptive name for the parameter: v

srkchowdary2000 · 2021-08-21T13:26:07Z

Added Borůvka's algorithm, a graph algorithm that finds the minimum spanning tree.

…panning tree.

srkchowdary2000 · 2021-08-21T16:18:44Z

This a Borůvka's algorithm, a simple greedy algorithm to find the Minimum spanning tree of a grap. It is also the oldest know graph algorithm, works as efficient as Kruskal's and Prim's algorithm.
Please review my code contribution.
@l3str4nge

l3str4nge

Please fix the tests :)

…panning tree. Solved Test Cases Errors.

srkchowdary2000 · 2021-08-21T19:28:53Z

Hi, I have Fixed the Tests. Can you please review the code. Thank you.
@l3str4nge

srkchowdary2000

Final Changes for Test Case Errors.

…panning tree. Solved Test Cases Errors.

srkchowdary2000

Test Case Errors Solved.

srkchowdary2000 · 2021-08-22T04:12:26Z

Hi, Can you please Review my Code.
@l3str4nge

l3str4nge · 2021-08-22T05:40:01Z

Please reformat with black because of precommit build

…panning tree. Solved Test Cases Errors.

srkchowdary2000

Final

l3str4nge · 2021-08-22T08:27:55Z

Not really :)

srkchowdary2000 · 2021-08-22T08:36:17Z

Even Spaces are not acceptable, is it? 😔
R

srkchowdary2000 · 2021-08-22T08:36:56Z

Rules are Strict. 😂

…panning tree. Solved Test Cases Errors.

srkchowdary2000

Precommiting seems difficult than writing Algorithm. Now Final Review Please.
@l3str4nge

…panning tree. Solved Test Cases Errors.

srkchowdary2000

Reduced Each Line Length, Code Formatting.
@l3str4nge

…panning tree. Solved Test Cases Errors.Removed WhiteSpaces.

srkchowdary2000

Removed WhiteSpaces.

srkchowdary2000 · 2021-08-23T04:04:55Z

Final Review Please.
@l3str4nge

l3str4nge · 2021-08-23T07:09:26Z

+
+
+class Graph:
+    """Class Graph."""


Unnecessary comment.

l3str4nge · 2021-08-23T07:10:37Z

+    def set_component(self, u_node: int) -> None:
+        """Finds the component index of a given node"""
+
+        if self.m_component[u_node] == u_node:


Would be just self.m_component[u_node] != u_node: and then we don't need else

l3str4nge · 2021-08-23T07:13:42Z

+            component_size[u_node] += component_size[v_node]
+            self.set_component(v_node)
+
+        print(self.m_component)


Please remove this print statement

l3str4nge · 2021-08-23T07:15:00Z

+        num_of_components = self.m_v
+
+        while num_of_components > 1:
+            for i in range(len(self.m_edges)):


Calling len() each iteration is inefficient.

…panning tree. Code Changes.

srkchowdary2000

Requested code changes done. Please review my code.
@l3str4nge

l3str4nge

Nice 🚀

srkchowdary2000 · 2021-08-23T10:40:31Z

* Added Borůvka's algorithm. * Added Borůvka's algorithm, a graph algorithm that finds the minimum spanning tree. * Added Borůvka's algorithm, a graph algorithm that finds the minimum spanning tree. * Added Borůvka's algorithm, a graph algorithm that finds the minimum spanning tree. * Added Borůvka's algorithm, a graph algorithm that finds the minimum spanning tree. * Added Borůvka's algorithm, a graph algorithm that finds the minimum spanning tree. Solved Test Cases Errors. * Added Borůvka's algorithm, a graph algorithm that finds the minimum spanning tree. Solved Test Cases Errors. * Added Borůvka's algorithm, a graph algorithm that finds the minimum spanning tree. Solved Test Cases Errors. * Added Borůvka's algorithm, a graph algorithm that finds the minimum spanning tree. Solved Test Cases Errors. * Added Borůvka's algorithm, a graph algorithm that finds the minimum spanning tree. Solved Test Cases Errors. * Added Borůvka's algorithm, a graph algorithm that finds the minimum spanning tree. Solved Test Cases Errors. * Added Borůvka's algorithm, a graph algorithm that finds the minimum spanning tree. Solved Test Cases Errors.Removed WhiteSpaces. * Added Borůvka's algorithm, a graph algorithm that finds the minimum spanning tree. Code Changes. * Added Borůvka's algorithm, a graph algorithm that finds the minimum spanning tree. Code Changes.

Added Borůvka's algorithm.

8d67fd5

ghost added awaiting reviews This PR is ready to be reviewed require descriptive names This PR needs descriptive function and/or variable names require type hints https://docs.python.org/3/library/typing.html labels Aug 21, 2021

ghost reviewed Aug 21, 2021

View reviewed changes

Added Borůvka's algorithm, a graph algorithm that finds the minimum s…

93e2298

…panning tree.

ghost reviewed Aug 21, 2021

View reviewed changes

srkchowdary2000 commented Aug 21, 2021

View reviewed changes

Added Borůvka's algorithm, a graph algorithm that finds the minimum s…

89cf0a4

…panning tree.

ghost removed the require type hints https://docs.python.org/3/library/typing.html label Aug 21, 2021

ghost reviewed Aug 21, 2021

View reviewed changes

Added Borůvka's algorithm, a graph algorithm that finds the minimum s…

d8b6132

…panning tree.

ghost removed the require descriptive names This PR needs descriptive function and/or variable names label Aug 21, 2021

Added Borůvka's algorithm, a graph algorithm that finds the minimum s…

88bb91e

…panning tree.

ghost added the tests are failing Do not merge until tests pass label Aug 21, 2021

l3str4nge requested changes Aug 21, 2021

View reviewed changes

ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Aug 21, 2021

Added Borůvka's algorithm, a graph algorithm that finds the minimum s…

c4a2e46

…panning tree. Solved Test Cases Errors.

ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Aug 21, 2021

srkchowdary2000 commented Aug 21, 2021

View reviewed changes

srkchowdary2000 added 2 commits August 22, 2021 01:39

Added Borůvka's algorithm, a graph algorithm that finds the minimum s…

ac6a863

…panning tree. Solved Test Cases Errors.

Added Borůvka's algorithm, a graph algorithm that finds the minimum s…

c01ccb9

…panning tree. Solved Test Cases Errors.

srkchowdary2000 commented Aug 21, 2021

View reviewed changes

srkchowdary2000 requested a review from l3str4nge August 21, 2021 20:22

srkchowdary2000 closed this Aug 21, 2021

srkchowdary2000 reopened this Aug 21, 2021

Added Borůvka's algorithm, a graph algorithm that finds the minimum s…

daa532c

…panning tree. Solved Test Cases Errors.

srkchowdary2000 commented Aug 22, 2021

View reviewed changes

Added Borůvka's algorithm, a graph algorithm that finds the minimum s…

3265907

…panning tree. Solved Test Cases Errors.

srkchowdary2000 commented Aug 22, 2021

View reviewed changes

Added Borůvka's algorithm, a graph algorithm that finds the minimum s…

0867092

…panning tree. Solved Test Cases Errors.

srkchowdary2000 commented Aug 22, 2021

View reviewed changes

Added Borůvka's algorithm, a graph algorithm that finds the minimum s…

f8125d7

…panning tree. Solved Test Cases Errors.Removed WhiteSpaces.

srkchowdary2000 commented Aug 22, 2021

View reviewed changes

ghost removed the tests are failing Do not merge until tests pass label Aug 23, 2021

l3str4nge requested changes Aug 23, 2021

View reviewed changes

ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Aug 23, 2021

Added Borůvka's algorithm, a graph algorithm that finds the minimum s…

e9af60a

…panning tree. Code Changes.

ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Aug 23, 2021

Added Borůvka's algorithm, a graph algorithm that finds the minimum s…

aba7767

…panning tree. Code Changes.

srkchowdary2000 commented Aug 23, 2021

View reviewed changes

l3str4nge approved these changes Aug 23, 2021

View reviewed changes

ghost removed the awaiting reviews This PR is ready to be reviewed label Aug 23, 2021

l3str4nge merged commit 4ed7c7f into TheAlgorithms:master Aug 23, 2021


		self.m_edges.append([u, v, weight])

		def find_component(self, u):


		self.m_edges.append([u, v, weight])

		def find_component(self, u) -> int:


		self.m_edges.append([u, v, weight])

		def find_component(self, u: int) -> int:

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

srkchowdary2000 commented Aug 21, 2021

Describe your change:

Checklist:

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

srkchowdary2000 left a comment

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

srkchowdary2000 commented Aug 21, 2021

Uh oh!

srkchowdary2000 commented Aug 21, 2021

Uh oh!

l3str4nge left a comment

Choose a reason for hiding this comment

Uh oh!

srkchowdary2000 commented Aug 21, 2021

Uh oh!

srkchowdary2000 left a comment

Choose a reason for hiding this comment

Uh oh!

srkchowdary2000 left a comment

Choose a reason for hiding this comment