Fix mypy error at maths by imp2002 · Pull Request #4613 · TheAlgorithms/Python · GitHub
Skip to content

Fix mypy error at maths - #4613

Merged
l3str4nge merged 6 commits into
TheAlgorithms:masterfrom
imp2002:mypy-fix-maths
Aug 15, 2021
Merged

Fix mypy error at maths#4613
l3str4nge merged 6 commits into
TheAlgorithms:masterfrom
imp2002:mypy-fix-maths

Conversation

@imp2002

@imp2002 imp2002 commented Aug 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Related issue #4052

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@imp2002
imp2002 requested a review from Kush1101 as a code owner August 15, 2021 04:46
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Aug 15, 2021
l3str4nge
l3str4nge requested changes Aug 15, 2021
View reviewed changes

@l3str4nge l3str4nge left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tests. See details in build logs

@ghost ghost added awaiting changes A maintainer has requested changes to this PR tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed labels Aug 15, 2021
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Aug 15, 2021
@imp2002
imp2002 requested a review from l3str4nge August 15, 2021 13:44
@l3str4nge

l3str4nge commented Aug 15, 2021

Copy link
Copy Markdown
Member

@imp2002

imp2002 commented Aug 15, 2021

Copy link
Copy Markdown
Member Author

@ghost ghost removed the tests are failing Do not merge until tests pass label Aug 15, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Aug 15, 2021
@l3str4nge
l3str4nge merged commit d009cea into TheAlgorithms:master Aug 15, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@imp2002 @shermanhui
Fix mypy error at maths (TheAlgorithms#4613)
fdfd613 
* Fix mypy errors for maths/greedy_coin_change.py

* Fix mypy errors for maths/two_sum.py

* Fix mypy errors for maths/triplet_sum.py

* Fix the format of maths/greedy_coin_change.py

* Fix the format of maths/greedy_coin_change.py

* Fix format with pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes
@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@imp2002 @l3str4nge