[fixed] module 'numpy' is imported with both 'import' and 'import from' by slowy07 · Pull Request #4544 · TheAlgorithms/Python · GitHub
Skip to content

[fixed] module 'numpy' is imported with both 'import' and 'import from' - #4544

Merged
l3str4nge merged 2 commits into
TheAlgorithms:masterfrom
slowy07:fix-module-import
Jul 26, 2021
Merged

[fixed] module 'numpy' is imported with both 'import' and 'import from'#4544
l3str4nge merged 2 commits into
TheAlgorithms:masterfrom
slowy07:fix-module-import

Conversation

@slowy07

@slowy07 slowy07 commented Jul 11, 2021

Copy link
Copy Markdown
Contributor

Describe your change:

fixing LGTM on arithmetic_analysis/lu_decomposition.py by:

  • fixing module numpy is imported with both 'import' and 'import from'
  • commented from numpy import ndarray
  • change ndarray to np.ndarray
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jul 11, 2021
@slowy07 slowy07 changed the title [fixed] module 'numy' is imported with both 'import' and 'import from' [fixed] module 'numpy' is imported with both 'import' and 'import from' Jul 12, 2021
l3str4nge
l3str4nge requested changes Jul 13, 2021
View reviewed changes
Comment thread arithmetic_analysis/lu_decomposition.py Outdated
@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Jul 13, 2021
@slowy07
slowy07 requested a review from l3str4nge July 13, 2021 12:20
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Jul 13, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jul 26, 2021
@l3str4nge
l3str4nge merged commit 6732fa0 into TheAlgorithms:master Jul 26, 2021
@slowy07
slowy07 deleted the fix-module-import branch July 26, 2021 14:12
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@slowy07 @shermanhui
[fixed] module 'numpy' is imported with both 'import' and 'import fro…
b599421 
…m' (TheAlgorithms#4544)

* [fixed] module 'numy' is imported with both 'import' and 'import from'

* remove commented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@slowy07 @l3str4nge