[Mypy fix] fix secant method by suyash2796 · Pull Request #4501 · TheAlgorithms/Python · GitHub
Skip to content

[Mypy fix] fix secant method - #4501

Merged
l3str4nge merged 6 commits into
TheAlgorithms:masterfrom
suyash2796:mypy-fix
Jul 21, 2021
Merged

[Mypy fix] fix secant method#4501
l3str4nge merged 6 commits into
TheAlgorithms:masterfrom
suyash2796:mypy-fix

Conversation

@suyash2796

@suyash2796 suyash2796 commented Jun 11, 2021

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Jun 11, 2021
@suyash2796 suyash2796 changed the title Mypy fix [Mypy fix] fix secant method Jun 11, 2021
PANDATD
PANDATD approved these changes Jun 11, 2021
View reviewed changes

@PANDATD PANDATD left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes made by contributor @suyash2796 is valid .

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jun 27, 2021
@l3str4nge
l3str4nge merged commit 407c979 into TheAlgorithms:master Jul 21, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@suyash2796 @shermanhui
[Mypy fix] fix secant method (TheAlgorithms#4501)
c6ed6b7 
* case switch using python

* review comments

* added type hints

* general code format

* [mypy] Fix type annotations for secant_method.py

* remove bad push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes
+2 more reviewers
@iamrajiv iamrajiv iamrajiv approved these changes
@PANDATD PANDATD PANDATD approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement This PR modified some existing files tests are failing Do not merge until tests pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suyash2796 @l3str4nge @iamrajiv @PANDATD