{{ message }}
feat(ci): Hash project euler solutions - #4411
Merged
Merged
Conversation
ghost
added
enhancement
Member
Member
|
@cclauss, please check the Discord and check the latest message. Thanks. 🙂 |
Contributor
Author
|
Yes I agree that they can't force this on us with the CC license, but since they just want the solutions in the JSON file for testing hashed so people won't just copy-paste everything from there, I don't see why we shouldn't do that. Is there any disadvantage for us in doing this? |
Member
We are an open source project. I am uncomfortable making decisions behind closed doors. The Euler Project’s Community Commons license does not give them the right to limit our use of their IP except as expressed in that license. If they want to change their license they can do so in the customary way. |
ghost
added
awaiting changes
siriak
reviewed
May 11, 2021
ghost
added
awaiting reviews
siriak
reviewed
May 11, 2021
siriak
reviewed
May 11, 2021
This comment has been minimized.
This comment has been minimized.
siriak
reviewed
May 11, 2021
siriak
reviewed
May 11, 2021
Panquesito7
approved these changes
May 11, 2021
Panquesito7
left a comment
Panquesito7
left a comment
Member
There was a problem hiding this comment.
Good work, @maltejur! Thank you! 🎉 👍
Panquesito7
dismissed
cclauss’s stale review
May 11, 2021 20:09
Continuous integration issues have been fixed.
ghost
added
awaiting reviews
Member
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
* hash project euler solutions * fix errors * Return missing annotation * Fix typo * Extract variable to shorten excessively long line * Update scripts/validate_solutions.py * Update scripts/validate_solutions.py * Simplify with str.encode() * PEP 585: type hinting generics in standard collections; * str().encode() * Texas two step to placate black, flake8, mypy Co-authored-by: Andrii Siriak <siryaka@gmail.com> Co-authored-by: Christian Clauss <cclauss@me.com>
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
* hash project euler solutions * fix errors * Return missing annotation * Fix typo * Extract variable to shorten excessively long line * Update scripts/validate_solutions.py * Update scripts/validate_solutions.py * Simplify with str.encode() * PEP 585: type hinting generics in standard collections; * str().encode() * Texas two step to placate black, flake8, mypy Co-authored-by: Andrii Siriak <siryaka@gmail.com> Co-authored-by: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
As requested from the Project Euler Team and already discussed in the discord, we should hash the values of the Project Euler solutions for testing so that no direct solutions are stored. This pr hashes all the values in the
project_euler_answers.jsonand updates the tests to use the hashed output.Checklist:
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.All new Python files are placed inside an existing directory.All functions have doctests that pass the automated testing.All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.