[mypy] Added/fixed type annotations for "crawl_google_results.py" by algobytewise · Pull Request #4234 · TheAlgorithms/Python · GitHub
Skip to content

[mypy] Added/fixed type annotations for "crawl_google_results.py" - #4234

Closed
algobytewise wants to merge 2 commits into
TheAlgorithms:masterfrom
algobytewise:mypy-fix-crawl_google_results.py
Closed

algobytewise wants to merge 2 commits into
TheAlgorithms:masterfrom
algobytewise:mypy-fix-crawl_google_results.py

Conversation

@algobytewise

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost

ghost commented Feb 23, 2021

Copy link
Copy Markdown

@ghost ghost closed this Feb 23, 2021
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Feb 23, 2021
@algobytewise
algobytewise deleted the mypy-fix-crawl_google_results.py branch March 21, 2021 10:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant