iframe-proxy

algobytewise · 2021-02-15T14:05:57Z

Implementation of the algorithm for the Koch snowflake

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

Implementation of the algorithm for the Koch snowflake

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-02-15T14:06:21Z

+
+
+# initial triangle of Koch snowflake
+VECTOR1 = numpy.array([0, 0])


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: VECTOR1

ghost · 2021-02-15T14:06:21Z

+
+# initial triangle of Koch snowflake
+VECTOR1 = numpy.array([0, 0])
+VECTOR2 = numpy.array([0.5, 0.8660254])


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: VECTOR2

ghost · 2021-02-15T14:06:22Z

+# initial triangle of Koch snowflake
+VECTOR1 = numpy.array([0, 0])
+VECTOR2 = numpy.array([0.5, 0.8660254])
+VECTOR3 = numpy.array([1, 0])


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: VECTOR3

ghost · 2021-02-15T14:06:22Z

+    return numpy.dot(rotation_matrix, vector)
+
+
+def plot(vectors: list[numpy.ndarray]) -> None:


As there is no test file in this pull request nor any test function or class in the file other/koch_snowflake.py, please provide doctest for the function plot

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-02-15T14:37:06Z

+
+
+# initial triangle of Koch snowflake
+VECTOR_1 = numpy.array([0, 0])


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: VECTOR_1

ghost · 2021-02-15T14:37:06Z

+
+# initial triangle of Koch snowflake
+VECTOR_1 = numpy.array([0, 0])
+VECTOR_2 = numpy.array([0.5, 0.8660254])


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: VECTOR_2

ghost · 2021-02-15T14:37:06Z

+# initial triangle of Koch snowflake
+VECTOR_1 = numpy.array([0, 0])
+VECTOR_2 = numpy.array([0.5, 0.8660254])
+VECTOR_3 = numpy.array([1, 0])


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: VECTOR_3

ghost · 2021-02-15T14:37:07Z

+    return numpy.dot(rotation_matrix, vector)
+
+
+def plot(vectors: list[numpy.ndarray]) -> None:


As there is no test file in this pull request nor any test function or class in the file other/koch_snowflake.py, please provide doctest for the function plot

algobytewise · 2021-02-15T14:50:34Z

Hello, it would be great if I could get some feedback on how to respond to the failed tests.
(1) algorithms-keeper complains that VECTOR_1, VECTOR_2 and VECTOR_3 are not snake_case. But they are intended as constants, not as variables.
(2) I'm not sure what doctest to implement for the plot-function. It is not part of the algorithm, it just draws a graph and it has no return value.

mrmaxguns · 2021-02-17T14:16:53Z

The bot just gives guidance. Tests failed because you didn't run isort. Here's the isort diff:

 from __future__ import annotations
-import numpy
 
+import numpy
 
 # initial triangle of Koch snowflake
 VECTOR_1 = numpy.array([0, 0])

As you can see, a newline was added between from __future__ import annotations and import numpy. The constants are fine. For the tests, you should probably add a small note in the relevant function why you chose not to include tests, so that future contributors know.

I fixed the sorting of the imports and I added a comment to the plot-function to explain what it does and why it doesn't use a doctest. Thank you to user mrmaxguns for suggesting these changes.

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-02-20T03:56:58Z

+    Utility function to plot the vectors using matplotlib.pyplot
+    No doctest was implemented since this function does not have a return value
+    """
+    import matplotlib.pyplot.


An error occured while parsing the file: other/koch_snowflake.py

Traceback (most recent call last): File "/app/.heroku/python/lib/python3.8/site-packages/libcst/_parser/base_parser.py", line 152, in _add_token plan = stack[-1].dfa.transitions[transition] KeyError: TokenType(NEWLINE) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/app/algorithms_keeper/parser/python_parser.py", line 145, in parse reports = lint_file( libcst._exceptions.ParserSyntaxError: Syntax Error @ 99:30. Incomplete input. Encountered '\r\n', but expected 'NAME'. import matplotlib.pyplot. ^

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-02-20T04:27:27Z

+import numpy
+
+# initial triangle of Koch snowflake
+VECTOR_1 = numpy.array([0, 0])


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: VECTOR_1

ghost · 2021-02-20T04:27:27Z

+
+# initial triangle of Koch snowflake
+VECTOR_1 = numpy.array([0, 0])
+VECTOR_2 = numpy.array([0.5, 0.8660254])


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: VECTOR_2

ghost · 2021-02-20T04:27:27Z

+# initial triangle of Koch snowflake
+VECTOR_1 = numpy.array([0, 0])
+VECTOR_2 = numpy.array([0.5, 0.8660254])
+VECTOR_3 = numpy.array([1, 0])


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: VECTOR_3

ghost · 2021-02-20T04:27:28Z

+    return numpy.dot(rotation_matrix, vector)
+
+
+def plot(vectors: list[numpy.ndarray]) -> None:


As there is no test file in this pull request nor any test function or class in the file other/koch_snowflake.py, please provide doctest for the function plot

algobytewise · 2021-02-20T04:31:09Z

Dear mrmaxguns, thank you for the feedback, I have implemented the changes you suggested.

cclauss · 2021-02-20T10:17:24Z

This looks good. Nice work. I am not a fan of uncategorized algorithms in the other directory because it makes it harder for visitors to find algorithms of interest. Would it make sense to move this to the cellular_automata or graphics directory instead?

cclauss · 2021-02-20T10:19:23Z

+    x_coordinates = []
+    for vector in vectors:
+        x_coordinates.append(vector[0])
+    y_coordinates = []
+    for vector in vectors:
+        y_coordinates.append(vector[1])


Please make these list comprehensions.

Or maybe even slicker, use zip() instead.

cclauss · 2021-02-20T10:20:36Z

+0.28867513]), array([0.66666667, 0.        ]), array([1, 0])]
+    """
+    new_vectors = []
+    for i in range(len(vectors) - 1):


range(len()) is almost always a sign that enumerate() could be used instead.

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-02-20T11:48:49Z

+    return numpy.dot(rotation_matrix, vector)
+
+
+def plot(vectors: list[numpy.ndarray]) -> None:


As there is no test file in this pull request nor any test function or class in the file graphics/koch_snowflake.py, please provide doctest for the function plot

algobytewise · 2021-02-20T11:52:41Z

I have implemented the changes, thanks for the advice on better looping. I think graphics is a better fit so I've put it there. My preferred solution would be to have a new directory for fractals and move it there together with other/sierpinski_triangle.py.

cclauss

LGTM

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-02-20T13:09:23Z

+    return numpy.dot(rotation_matrix, vector)
+
+
+def plot(vectors: list[numpy.ndarray]) -> None:


As there is no test file in this pull request nor any test function or class in the file graphics/koch_snowflake.py, please provide doctest for the function plot

…#4207) * Add files via upload Implementation of the algorithm for the Koch snowflake * added underscore to variable names * added newline and comment I fixed the sorting of the imports and I added a comment to the plot-function to explain what it does and why it doesn't use a doctest. Thank you to user mrmaxguns for suggesting these changes. * fixed accidental newline in the middle of expression * improved looping * moved "koch_snowflake.py" from "other" to "graphics" * Update koch_snowflake.py Co-authored-by: Christian Clauss <cclauss@me.com>

Add files via upload

0a316a5

Implementation of the algorithm for the Koch snowflake

ghost added the require tests Tests [doctest/unittest/pytest] are required label Feb 15, 2021

ghost reviewed Feb 15, 2021

View reviewed changes

ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Feb 15, 2021

added underscore to variable names

526f49d

ghost reviewed Feb 15, 2021

View reviewed changes

added newline and comment

62f0d60

I fixed the sorting of the imports and I added a comment to the plot-function to explain what it does and why it doesn't use a doctest. Thank you to user mrmaxguns for suggesting these changes.

ghost removed the require tests Tests [doctest/unittest/pytest] are required label Feb 20, 2021

ghost reviewed Feb 20, 2021

View reviewed changes

fixed accidental newline in the middle of expression

4530a56

ghost added the require tests Tests [doctest/unittest/pytest] are required label Feb 20, 2021

ghost reviewed Feb 20, 2021

View reviewed changes

ghost removed the tests are failing Do not merge until tests pass label Feb 20, 2021

cclauss reviewed Feb 20, 2021

View reviewed changes

algobytewise added 2 commits February 20, 2021 17:16

improved looping

4224ad4

moved "koch_snowflake.py" from "other" to "graphics"

84de200

ghost reviewed Feb 20, 2021

View reviewed changes

Update koch_snowflake.py

3ef66be

cclauss approved these changes Feb 20, 2021

View reviewed changes

ghost reviewed Feb 20, 2021

View reviewed changes

ghost removed the awaiting reviews This PR is ready to be reviewed label Feb 20, 2021

cclauss merged commit 6bb9a02 into TheAlgorithms:master Feb 20, 2021



		# initial triangle of Koch snowflake
		VECTOR1 = numpy.array([0, 0])

		return numpy.dot(rotation_matrix, vector)


		def plot(vectors: list[numpy.ndarray]) -> None:



		# initial triangle of Koch snowflake
		VECTOR_1 = numpy.array([0, 0])

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

algobytewise commented Feb 15, 2021

Describe your change:

Checklist:

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

algobytewise commented Feb 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrmaxguns commented Feb 17, 2021

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

algobytewise commented Feb 20, 2021

Uh oh!

cclauss commented Feb 20, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

algobytewise commented Feb 15, 2021 •

edited

Loading