add count_number_of_one_bits.py by ayushbisht2001 · Pull Request #4195 · TheAlgorithms/Python · GitHub
Skip to content

add count_number_of_one_bits.py - #4195

Merged
ruppysuppy merged 2 commits into
TheAlgorithms:masterfrom
ayushbisht2001:my-contrib
Feb 12, 2021
Merged

add count_number_of_one_bits.py#4195
ruppysuppy merged 2 commits into
TheAlgorithms:masterfrom
ayushbisht2001:my-contrib

Conversation

@ayushbisht2001

@ayushbisht2001 ayushbisht2001 commented Feb 10, 2021

Copy link
Copy Markdown
Contributor

Describe your change:

I have added an algorithm which counts the number of one (on bits) bits in a given positive integer.

  • Add an algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Feb 10, 2021
ruppysuppy
ruppysuppy suggested changes Feb 11, 2021
View reviewed changes
Comment thread bit_manipulation/count_number_of_one_bits.py Outdated
Comment thread bit_manipulation/count_number_of_one_bits.py Outdated
@ghost ghost added awaiting changes A maintainer has requested changes to this PR awaiting reviews This PR is ready to be reviewed and removed awaiting reviews This PR is ready to be reviewed awaiting changes A maintainer has requested changes to this PR labels Feb 11, 2021
ayushbisht2001
ayushbisht2001 commented Feb 11, 2021
View reviewed changes

@ayushbisht2001 ayushbisht2001 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@ghost ghost added the tests are failing Do not merge until tests pass label Feb 11, 2021
@ayushbisht2001

ayushbisht2001 commented Feb 11, 2021

Copy link
Copy Markdown
Contributor Author

@ruppysuppy

ruppysuppy commented Feb 11, 2021

Copy link
Copy Markdown
Member

The check are failing because of wrong format, presumably due to extra space and wrong doctest please correct them, using flake8 and recheck the doctests

@ghost ghost removed the tests are failing Do not merge until tests pass label Feb 11, 2021
@ayushbisht2001

ayushbisht2001 commented Feb 11, 2021

Copy link
Copy Markdown
Contributor Author

@ruppysuppy
ruppysuppy merged commit d3ac521 into TheAlgorithms:master Feb 12, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Feb 12, 2021
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@ayushbisht2001 @peRFectBeliever
add count_number_of_one_bits.py (TheAlgorithms#4195)
2b09c4b 
* count-bits

* update
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@ayushbisht2001
add count_number_of_one_bits.py (TheAlgorithms#4195)
8b54695 
* count-bits

* update
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@ayushbisht2001 @shermanhui
add count_number_of_one_bits.py (TheAlgorithms#4195)
620c848 
* count-bits

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ruppysuppy ruppysuppy ruppysuppy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ayushbisht2001 @ruppysuppy