Fix pre-commit error on master by dhruvmanila · Pull Request #3992 · TheAlgorithms/Python · GitHub
Skip to content

Fix pre-commit error on master - #3992

Merged
dhruvmanila merged 3 commits into
masterfrom
dhruvmanila/fix-pre-commit
Nov 30, 2020
Merged

Fix pre-commit error on master#3992
dhruvmanila merged 3 commits into
masterfrom
dhruvmanila/fix-pre-commit

Conversation

@dhruvmanila

@dhruvmanila dhruvmanila commented Nov 30, 2020

Copy link
Copy Markdown
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed require type hints https://docs.python.org/3/library/typing.html labels Nov 30, 2020
@ghost

ghost commented Nov 30, 2020 •
edited by realDuYuanChao
Loading

Copy link
Copy Markdown

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 30, 2020
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed require type hints https://docs.python.org/3/library/typing.html labels Nov 30, 2020
@dhruvmanila
dhruvmanila requested a review from cclauss November 30, 2020 15:06
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 30, 2020
@dhruvmanila
dhruvmanila merged commit f8b2c43 into master Nov 30, 2020
@dhruvmanila
dhruvmanila deleted the dhruvmanila/fix-pre-commit branch November 30, 2020 15:33
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@dhruvmanila github-actions @stokhos
Fix pre-commit error on master (TheAlgorithms#3992)
1eeb48c 
* Update pigeon_sort.py

* updating DIRECTORY.md

* Add type hints and return annotation

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@dhruvmanila github-actions @peRFectBeliever
Fix pre-commit error on master (TheAlgorithms#3992)
40e6b13 
* Update pigeon_sort.py

* updating DIRECTORY.md

* Add type hints and return annotation

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@dhruvmanila github-actions
Fix pre-commit error on master (TheAlgorithms#3992)
9aa5a02 
* Update pigeon_sort.py

* updating DIRECTORY.md

* Add type hints and return annotation

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@dhruvmanila github-actions @shermanhui
Fix pre-commit error on master (TheAlgorithms#3992)
355697f 
* Update pigeon_sort.py

* updating DIRECTORY.md

* Add type hints and return annotation

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes
@l3str4nge l3str4nge Awaiting requested review from l3str4nge

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhruvmanila @cclauss