Fix mypy in #2684 by poyea · Pull Request #3987 · TheAlgorithms/Python · GitHub
Skip to content

Fix mypy in #2684 - #3987

Merged
dhruvmanila merged 2 commits into
TheAlgorithms:masterfrom
poyea:fix-mypy
Nov 29, 2020
Merged

Fix mypy in #2684#3987
dhruvmanila merged 2 commits into
TheAlgorithms:masterfrom
poyea:fix-mypy

Conversation

@poyea

@poyea poyea commented Nov 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Describe your change:

Fix mypy errors made in #2684.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Nov 29, 2020
@ghost

ghost commented Nov 29, 2020

Copy link
Copy Markdown

@ghost ghost added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required and removed awaiting reviews This PR is ready to be reviewed labels Nov 29, 2020
@ghost ghost added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Nov 29, 2020
dhruvmanila
dhruvmanila approved these changes Nov 29, 2020
View reviewed changes

@dhruvmanila dhruvmanila left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mypy passes for all files ❤️
Awesome job! Thanks for doing this 😄

@dhruvmanila
dhruvmanila merged commit 25164bb into TheAlgorithms:master Nov 29, 2020
@poyea
poyea deleted the fix-mypy branch November 29, 2020 17:31
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@poyea @stokhos
Fix mypy in TheAlgorithms#2684 (TheAlgorithms#3987)
5b9f710 
* Fix mypy in TheAlgorithms#2684

* fix pre-commit
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@poyea @peRFectBeliever
Fix mypy in TheAlgorithms#2684 (TheAlgorithms#3987)
6afee53 
* Fix mypy in TheAlgorithms#2684

* fix pre-commit
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@poyea
Fix mypy in TheAlgorithms#2684 (TheAlgorithms#3987)
a834991 
* Fix mypy in TheAlgorithms#2684

* fix pre-commit
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@poyea @shermanhui
Fix mypy in TheAlgorithms#2684 (TheAlgorithms#3987)
8f9b7e8 
* Fix mypy in TheAlgorithms#2684

* fix pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees

No one assigned

Labels

require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@poyea @dhruvmanila