Fixed LGTM and typehint by realDuYuanChao · Pull Request #3970 · TheAlgorithms/Python · GitHub
Skip to content

Fixed LGTM and typehint - #3970

Merged
poyea merged 4 commits into
TheAlgorithms:masterfrom
realDuYuanChao:fixed-lgtm-typehint
Nov 28, 2020
Merged

Fixed LGTM and typehint#3970
poyea merged 4 commits into
TheAlgorithms:masterfrom
realDuYuanChao:fixed-lgtm-typehint

Conversation

@realDuYuanChao

@realDuYuanChao realDuYuanChao commented Nov 27, 2020

Copy link
Copy Markdown
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed require descriptive names This PR needs descriptive function and/or variable names labels Nov 27, 2020
@ghost

ghost commented Nov 27, 2020 •
edited by poyea
Loading

Copy link
Copy Markdown

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 27, 2020
@dhruvmanila

dhruvmanila commented Nov 27, 2020

Copy link
Copy Markdown
Member

poyea
poyea approved these changes Nov 28, 2020
View reviewed changes

@poyea poyea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed require descriptive names This PR needs descriptive function and/or variable names labels Nov 28, 2020
@ghost ghost added tests are failing Do not merge until tests pass awaiting reviews This PR is ready to be reviewed and removed awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Nov 28, 2020
@poyea
poyea merged commit bfb0c35 into TheAlgorithms:master Nov 28, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@realDuYuanChao github-actions
@poyea @stokhos
Fixed LGTM and typehint (TheAlgorithms#3970)
737e6f7 
* fixed LGTM
fixed typehint

* updating DIRECTORY.md

* Update lucas_series.py

* Update lucas_series.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <johnlaw.po@gmail.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@realDuYuanChao github-actions
@poyea @peRFectBeliever
Fixed LGTM and typehint (TheAlgorithms#3970)
c14d5e3 
* fixed LGTM
fixed typehint

* updating DIRECTORY.md

* Update lucas_series.py

* Update lucas_series.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <johnlaw.po@gmail.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@realDuYuanChao github-actions @poyea
Fixed LGTM and typehint (TheAlgorithms#3970)
f1023ca 
* fixed LGTM
fixed typehint

* updating DIRECTORY.md

* Update lucas_series.py

* Update lucas_series.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <johnlaw.po@gmail.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@realDuYuanChao github-actions
@poyea @shermanhui
Fixed LGTM and typehint (TheAlgorithms#3970)
b429937 
* fixed LGTM
fixed typehint

* updating DIRECTORY.md

* Update lucas_series.py

* Update lucas_series.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <johnlaw.po@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea approved these changes
@Kush1101 Kush1101 Awaiting requested review from Kush1101
@cclauss cclauss Awaiting requested review from cclauss
@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@realDuYuanChao @dhruvmanila @poyea