{{ message }}
Fix handling of non ascii characters in swap case (fixes: #3847) - #3848
Merged
dhruvmanila merged 4 commits intoNov 6, 2020
Conversation
Contributor
Author
Member
dhruvmanila
approved these changes
Nov 6, 2020
dhruvmanila
left a comment
dhruvmanila
left a comment
Member
There was a problem hiding this comment.
Thank you for fixing this issue!
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
…ms#3847) (TheAlgorithms#3848) * TheAlgorithms#3847 fix handling of non-ASCII characters in swap_case * TheAlgorithms#3847 remove unused regex * Fix formatting (with black) Fixes: TheAlgorithms#3847 * Add type hints for `swap_case` function Co-authored-by: Frank Schmitt <frankschmitt@gmx.de> Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
peRFectBeliever
pushed a commit
to peRFectBeliever/Python
that referenced
this pull request
Apr 1, 2021
…ms#3847) (TheAlgorithms#3848) * TheAlgorithms#3847 fix handling of non-ASCII characters in swap_case * TheAlgorithms#3847 remove unused regex * Fix formatting (with black) Fixes: TheAlgorithms#3847 * Add type hints for `swap_case` function Co-authored-by: Frank Schmitt <frankschmitt@gmx.de> Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
…ms#3847) (TheAlgorithms#3848) * TheAlgorithms#3847 fix handling of non-ASCII characters in swap_case * TheAlgorithms#3847 remove unused regex * Fix formatting (with black) Fixes: TheAlgorithms#3847 * Add type hints for `swap_case` function Co-authored-by: Frank Schmitt <frankschmitt@gmx.de> Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
…ms#3847) (TheAlgorithms#3848) * TheAlgorithms#3847 fix handling of non-ASCII characters in swap_case * TheAlgorithms#3847 remove unused regex * Fix formatting (with black) Fixes: TheAlgorithms#3847 * Add type hints for `swap_case` function Co-authored-by: Frank Schmitt <frankschmitt@gmx.de> Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
This fixes 3847 - handling of non-ASCII characters in swap_case.
Output before (buggy):
python3 swap_case.py
Please input sentence:äü
ÄäÜü
Output now (correct):
python3 swap_case.py
Please input sentence:äü
ÄÜ
Checklist:
Fixes: #{$ISSUE_NO}.=> It's not contained in the commit messages, but in the PR description. I hope this will suffice. Otherwise, I can of course add a dummy commit.