A divide and conquer method in finding the maximum difference pair by choyiny · Pull Request #3692 · TheAlgorithms/Python · GitHub
Skip to content

A divide and conquer method in finding the maximum difference pair - #3692

Merged
poyea merged 4 commits into
TheAlgorithms:masterfrom
choyiny:dnc/max-pair
Nov 25, 2020
Merged

A divide and conquer method in finding the maximum difference pair#3692
poyea merged 4 commits into
TheAlgorithms:masterfrom
choyiny:dnc/max-pair

Conversation

@choyiny

@choyiny choyiny commented Oct 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost

ghost commented Oct 24, 2020

Copy link
Copy Markdown

ghost
ghost approved these changes Oct 24, 2020
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work

poyea
poyea reviewed Oct 24, 2020
View reviewed changes

@poyea poyea left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a main function:

if __name__ == "__main__":
    import doctest

    doctest.testmod()

@poyea poyea self-assigned this Oct 24, 2020
@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 24, 2020
@ghost

ghost commented Oct 24, 2020

Copy link
Copy Markdown

@poyea check this out (Changes made)

@stale

stale Bot commented Nov 24, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Used to mark an issue or pull request stale. label Nov 24, 2020
@choyiny

choyiny commented Nov 24, 2020

Copy link
Copy Markdown
Contributor Author

See if this is sufficient for merge, thanks.

@stale stale Bot removed the stale Used to mark an issue or pull request stale. label Nov 24, 2020
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Nov 24, 2020
poyea
poyea approved these changes Nov 24, 2020
View reviewed changes

@poyea poyea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the value the function returns is a pair of 2 array values, right? You may modify the comment if that's the case. Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 24, 2020
@choyiny

choyiny commented Nov 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I think the value the function returns is a pair of 2 array values, right? You may modify the comment if that's the case. Thank you for your pull request!🤩

The return is a 2-tuple of integers, actually, which is the comment.

@poyea

poyea commented Nov 25, 2020

Copy link
Copy Markdown
Member

@poyea
poyea merged commit 287bf26 into TheAlgorithms:master Nov 25, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@choyiny @stokhos
Add a divide and conquer method in finding the maximum difference pair (
1cf7764 
TheAlgorithms#3692)

* A divide and conquer method in finding the maximum difference pair

* fix formatting issues

* fix formatting issues

* add doctest runner
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@choyiny @peRFectBeliever
Add a divide and conquer method in finding the maximum difference pair (
d485986 
TheAlgorithms#3692)

* A divide and conquer method in finding the maximum difference pair

* fix formatting issues

* fix formatting issues

* add doctest runner
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@choyiny
Add a divide and conquer method in finding the maximum difference pair (
88409d3 
TheAlgorithms#3692)

* A divide and conquer method in finding the maximum difference pair

* fix formatting issues

* fix formatting issues

* add doctest runner
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@choyiny @shermanhui
Add a divide and conquer method in finding the maximum difference pair (
73e89e8 
TheAlgorithms#3692)

* A divide and conquer method in finding the maximum difference pair

* fix formatting issues

* fix formatting issues

* add doctest runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea approved these changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

@poyea poyea

Labels

hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@choyiny @poyea