Hacktoberfest:Added first solution to Project Euler problem 58 by sharmapulkit04 · Pull Request #3599 · TheAlgorithms/Python · GitHub
Skip to content

Hacktoberfest:Added first solution to Project Euler problem 58 - #3599

Merged
poyea merged 2 commits into
TheAlgorithms:masterfrom
sharmapulkit04:pr2
Oct 29, 2020
Merged

Hacktoberfest:Added first solution to Project Euler problem 58#3599
poyea merged 2 commits into
TheAlgorithms:masterfrom
sharmapulkit04:pr2

Conversation

@sharmapulkit04

@sharmapulkit04 sharmapulkit04 commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

poyea
poyea approved these changes Oct 29, 2020
View reviewed changes

@poyea poyea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@poyea
poyea merged commit e172a8b into TheAlgorithms:master Oct 29, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@sharmapulkit04 @poyea @stokhos
Hacktoberfest: Added first solution to Project Euler problem 58 (TheA…
8a7942c 
…lgorithms#3599)

* Added solution to problem 58

* Update sol1.py

Co-authored-by: John Law <johnlaw.po@gmail.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@sharmapulkit04 @poyea @peRFectBeliever
Hacktoberfest: Added first solution to Project Euler problem 58 (TheA…
5b5c518 
…lgorithms#3599)

* Added solution to problem 58

* Update sol1.py

Co-authored-by: John Law <johnlaw.po@gmail.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@sharmapulkit04 @poyea
Hacktoberfest: Added first solution to Project Euler problem 58 (TheA…
73a7bf9 
…lgorithms#3599)

* Added solution to problem 58

* Update sol1.py

Co-authored-by: John Law <johnlaw.po@gmail.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@sharmapulkit04 @poyea @shermanhui
Hacktoberfest: Added first solution to Project Euler problem 58 (TheA…
973b53e 
…lgorithms#3599)

* Added solution to problem 58

* Update sol1.py

Co-authored-by: John Law <johnlaw.po@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea approved these changes
@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila
@Kush1101 Kush1101 Awaiting requested review from Kush1101
+1 more reviewer
@kbakdev kbakdev kbakdev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sharmapulkit04 @poyea @kbakdev