Made small improvements and shortened prime_check.py by Rolv-Apneseth · Pull Request #3454 · TheAlgorithms/Python · GitHub
Skip to content

Made small improvements and shortened prime_check.py - #3454

Merged
poyea merged 3 commits into
TheAlgorithms:masterfrom
Rolv-Apneseth:improve-prime_check.py
Oct 23, 2020
Merged

poyea merged 3 commits into
TheAlgorithms:masterfrom
Rolv-Apneseth:improve-prime_check.py

Conversation

@Rolv-Apneseth

Copy link
Copy Markdown
Contributor

Describe your change:

Made small improvements and shortened prime_check.py
Shortened overall code and changed some of the comments/docstrings

For issue #3453

@Rolv-Apneseth

Copy link
Copy Markdown
Contributor Author

@Rolv-Apneseth

Copy link
Copy Markdown
Contributor Author

Pre-commit check is not failing on self.assertFalse(prime_check(2 * 3)) but when run locally, all tests succeed, and running prime_check(2 * 3) returns False as it should so I'm confused

@poyea

poyea commented Oct 22, 2020

Copy link
Copy Markdown
Member

Please run black . for your code. https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md

@poyea

poyea commented Oct 22, 2020

Copy link
Copy Markdown
Member

I think you can enable the github actions in your setting of the fork too.

@Rolv-Apneseth

Rolv-Apneseth commented Oct 22, 2020

Copy link
Copy Markdown
Contributor Author

@poyea poyea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@poyea
poyea merged commit 04fae4d into TheAlgorithms:master Oct 23, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Made small improvements and shortened prime_check.py

* improved descriptions on tests in prime_check.py

* Ran black and isort
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
* Made small improvements and shortened prime_check.py

* improved descriptions on tests in prime_check.py

* Ran black and isort
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Made small improvements and shortened prime_check.py

* improved descriptions on tests in prime_check.py

* Ran black and isort
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
* Made small improvements and shortened prime_check.py

* improved descriptions on tests in prime_check.py

* Ran black and isort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants