iframe-proxy

mayur200 · 2020-10-11T22:13:16Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?
I have added an algorithm for swap case in string folder
This pull request is all my own work -- I have not plagiarized.
I have fixed unexpected expression part from 2 algorithm.
All functions and variable names follow Python naming conventions.

Checklist:

…ram.

TravisBuddy · 2020-10-11T22:21:01Z

cclauss · 2020-10-12T00:28:09Z

    user_input = input("Enter numbers separated by a comma:\n").strip()
    unsorted = [int(item) for item in user_input.split(",")]
-    print(f"{cocktail_shaker_sort(unsorted) = }")
+    print(f"{cocktail_shaker_sort(unsorted) }")


Why break this?

I was getting error in pycharm 'unexpected expression part' before running a program.

I have fixed it again and I have commited changes. Sorry for the inconvenience

cclauss · 2020-10-12T00:28:37Z

 if __name__ == "__main__":
    assert naive_pattern_search("ABCDEFG", "DE") == [3]
-    print(f"{naive_pattern_search('ABAAABCDBBABCDDEBCABC', 'ABC') = }")
+    print(f"{naive_pattern_search('ABAAABCDBBABCDDEBCABC', 'ABC')}")


Why break this?

I was getting error in pycharm 'unexpected expression part' before running a program.

Pycharm is not upgraded to Python 3.8 and 3.9 which support this functionality.

I have fixed this

cclauss · 2020-10-12T00:30:18Z

+    """
+    if len(sentence) < 1001:
+        newstring = ''
+        for word in sentence:


These are not words. They are char.

ok. I will fix it

I have fixed it and commit the changes

cclauss · 2020-10-12T00:30:47Z

+    else:
+        raise Exception("Charater length should be between 1 and 1000")


I have raise an exception and its readable. If its not relatable should I remove it?

No. I mean why create a 1000 character limit? Just process the string no matter how long it is.

I have removed condition

cclauss · 2020-10-12T00:32:21Z

+def swap_case(sentence):
+    """
+    This function will convert all lowercase letters to uppercase letters and vice versa.
+    >>>swap_case('Algorithm.Python@89')


Suggested change

>>>swap_case('Algorithm.Python@89')

>>> swap_case('Algorithm.Python@89')

Without the space, the test is never run.

I will fix it

I have added space. I have commited changes

cclauss · 2020-10-12T00:32:50Z

+2)>>>Please input sentence: github.com/mayur200
+  GITHUB.COM/MAYUR200
+
+Constraints: Length of string should between 1 and 1000


Its example for problem statement. If someone failed to understand the problem. This example is self explanatory

No. I mean why create a 1000 character limit? Just process the string no matter how long it is.

Ok. I will fix it.

I have fixed it and I have pushed changes

cclauss · 2020-10-12T00:33:46Z

All tests are failing.

… pycharm

TravisBuddy · 2020-10-14T20:09:53Z

Travis tests have failed

Hey @mayur200,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 1e9101f0-0e59-11eb-964d-5d54b4986782

TravisBuddy · 2020-10-14T20:11:46Z

Travis tests have failed

Hey @mayur200,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7a45e010-0e59-11eb-964d-5d54b4986782

TravisBuddy · 2020-10-14T20:18:54Z

Travis tests have failed

Hey @mayur200,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 790c3220-0e5a-11eb-964d-5d54b4986782

TravisBuddy · 2020-10-14T20:22:50Z

Travis tests have failed

Hey @mayur200,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 0603d7a0-0e5b-11eb-964d-5d54b4986782

TravisBuddy · 2020-10-14T20:24:53Z

Travis tests have failed

Hey @mayur200,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 4eda6340-0e5b-11eb-964d-5d54b4986782

TravisBuddy · 2020-10-14T20:28:47Z

Travis tests have failed

Hey @mayur200,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: bff9e410-0e5b-11eb-964d-5d54b4986782

TravisBuddy · 2020-10-14T20:34:17Z

Travis tests have failed

Hey @mayur200,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 9ed5bd80-0e5c-11eb-964d-5d54b4986782

TravisBuddy · 2020-10-14T20:41:03Z

Travis tests have failed

Hey @mayur200,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 913ca430-0e5d-11eb-964d-5d54b4986782

TravisBuddy · 2020-10-14T20:48:04Z

Travis tests have failed

Hey @mayur200,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 8be5a5d0-0e5e-11eb-964d-5d54b4986782

mayur200 · 2020-10-14T20:58:52Z

Why my test is failed again??
I am confused I don't know why its failed my program gives me perfect output

cclauss · 2020-10-14T21:03:55Z

https://travis-ci.com/github/TheAlgorithms/Python/jobs/399797450#L775

TravisBuddy · 2020-10-14T21:47:08Z

Travis tests have failed

Hey @mayur200,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: cc658370-0e66-11eb-964d-5d54b4986782

TravisBuddy · 2020-10-14T21:55:38Z

Travis tests have failed

Hey @mayur200,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: df9cfd00-0e67-11eb-964d-5d54b4986782

TravisBuddy · 2020-10-14T22:05:07Z

Travis tests have failed

Hey @mayur200,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 4faa06f0-0e69-11eb-964d-5d54b4986782

TravisBuddy · 2020-10-14T22:10:18Z

…gorithms#3212) * Removed an extra '=' which was creating an error while running a program. * Removed the unexpected expression part. * Added program for swap cases in string folder * removed if condition and exchange word with char * added '=' sign which I removed before because of unknowing error from pycharm * added space in test * removed costraint from problem statement * Update cocktail_shaker_sort.py * Update naive_string_search.py * Update swap_case.py * psf/black " not ' * added new line at the end of the file * Fix flake8 issues * added new line at the end of the file * added True and fixed comment * python file end with \n * Update swap_case.py * Update strings/swap_case.py * Update strings/swap_case.py * Apply suggestions from code review * Update strings/swap_case.py * Update swap_case.py * Update swap_case.py Co-authored-by: Christian Clauss <cclauss@me.com>

mayur200 added 3 commits October 12, 2020 02:21

Removed an extra '=' which was creating an error while running a prog…

584ce63

…ram.

Removed the unexpected expression part.

91d8bf3

Added program for swap cases in string folder

8453420

mayur200 requested a review from cclauss as a code owner October 11, 2020 22:13

cclauss requested changes Oct 12, 2020

View reviewed changes

removed if condition and exchange word with char

c9d1b7d

mayur200 requested a review from l3str4nge as a code owner October 14, 2020 20:02

added '=' sign which I removed before because of unknowing error from…

0a512bb

… pycharm

mayur200 and others added 4 commits October 15, 2020 01:43

added space in test

0315f02

removed costraint from problem statement

018bb9f

Update cocktail_shaker_sort.py

d823ec1

Update naive_string_search.py

94b71b4

Update swap_case.py

f8ae23b

psf/black " not '

145ffe0

added new line at the end of the file

18c8286

Fix flake8 issues

ab606cd

mayur200 added 3 commits October 15, 2020 02:04

added new line at the end of the file

8ca8a89

Merge branch 'master' of https://github.com/mayur200/Python

bbf21ca

added new line at the end of the file

752bc5d

added True and fixed comment

ef73619

cclauss reviewed Oct 14, 2020

View reviewed changes

Comment thread strings/swap_case.py Outdated

cclauss reviewed Oct 14, 2020

View reviewed changes

Comment thread strings/swap_case.py Outdated

python file end with \n

353eaed

Update swap_case.py

08209ff

cclauss reviewed Oct 14, 2020

View reviewed changes

Comment thread strings/swap_case.py Outdated

cclauss reviewed Oct 14, 2020

View reviewed changes

Comment thread strings/swap_case.py Outdated

cclauss reviewed Oct 14, 2020

View reviewed changes

Comment thread strings/swap_case.py Outdated

cclauss reviewed Oct 14, 2020

View reviewed changes

Comment thread strings/swap_case.py Outdated

cclauss reviewed Oct 14, 2020

View reviewed changes

Comment thread strings/swap_case.py Outdated

cclauss reviewed Oct 14, 2020

View reviewed changes

Comment thread strings/swap_case.py Outdated

cclauss reviewed Oct 14, 2020

View reviewed changes

Comment thread strings/swap_case.py Outdated

cclauss reviewed Oct 14, 2020

View reviewed changes

Comment thread strings/swap_case.py Outdated

cclauss added 3 commits October 14, 2020 23:57

Update strings/swap_case.py

14024a8

Update strings/swap_case.py

bcfcb21

Apply suggestions from code review

81f89eb

cclauss reviewed Oct 14, 2020

View reviewed changes

Comment thread strings/swap_case.py

cclauss added 2 commits October 14, 2020 23:59

Update strings/swap_case.py

421fa61

Update swap_case.py

30863af

Update swap_case.py

79d37c4

cclauss approved these changes Oct 14, 2020

View reviewed changes

cclauss merged commit ed30749 into TheAlgorithms:master Oct 14, 2020

		else:
		raise Exception("Charater length should be between 1 and 1000")

	>>>swap_case('Algorithm.Python@89')
	>>> swap_case('Algorithm.Python@89')

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

mayur200 commented Oct 11, 2020

Describe your change:

Checklist:

Uh oh!

TravisBuddy commented Oct 11, 2020

Travis tests have failed

TravisBuddy Request Identifier: f141dbc0-0c0f-11eb-a59b-f3f3774a9991

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mayur200 Oct 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cclauss commented Oct 12, 2020

Uh oh!

TravisBuddy commented Oct 14, 2020

Travis tests have failed

TravisBuddy Request Identifier: 1e9101f0-0e59-11eb-964d-5d54b4986782

Uh oh!

TravisBuddy commented Oct 14, 2020

Travis tests have failed

TravisBuddy Request Identifier: 7a45e010-0e59-11eb-964d-5d54b4986782

Uh oh!

TravisBuddy commented Oct 14, 2020

Travis tests have failed

TravisBuddy Request Identifier: 790c3220-0e5a-11eb-964d-5d54b4986782

Uh oh!

TravisBuddy commented Oct 14, 2020

Travis tests have failed

TravisBuddy Request Identifier: 0603d7a0-0e5b-11eb-964d-5d54b4986782

Uh oh!

TravisBuddy commented Oct 14, 2020

Travis tests have failed

mayur200 Oct 13, 2020 •

edited

Loading