CONTRIBUTING.md Jupyter files belong in the Jupyter repo. by cclauss · Pull Request #3211 · TheAlgorithms/Python · GitHub
Skip to content

CONTRIBUTING.md Jupyter files belong in the Jupyter repo. - #3211

Merged
poyea merged 3 commits into
masterfrom
Jupyter-files
Oct 12, 2020
Merged

CONTRIBUTING.md Jupyter files belong in the Jupyter repo.#3211
poyea merged 3 commits into
masterfrom
Jupyter-files

Conversation

@cclauss

@cclauss cclauss commented Oct 11, 2020

Copy link
Copy Markdown
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss
cclauss requested review from dhruvmanila and poyea October 11, 2020 22:02
poyea
poyea approved these changes Oct 12, 2020
View reviewed changes

@poyea poyea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@poyea
poyea merged commit f7e7ad2 into master Oct 12, 2020
@poyea
poyea deleted the Jupyter-files branch October 12, 2020 00:17
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@cclauss github-actions
@poyea @stokhos
CONTRIBUTING.md Jupyter files belong in the Jupyter repo. (TheAlgorit…
26f2bb9 
…hms#3211)

* CONTRIBUTING.md Jupyter files belong in the Jupyter repo.

* updating DIRECTORY.md

* Update CONTRIBUTING.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <johnlaw.po@gmail.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@cclauss github-actions @poyea
CONTRIBUTING.md Jupyter files belong in the Jupyter repo. (TheAlgorit…
cc0678b 
…hms#3211)

* CONTRIBUTING.md Jupyter files belong in the Jupyter repo.

* updating DIRECTORY.md

* Update CONTRIBUTING.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <johnlaw.po@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea approved these changes
@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cclauss @poyea