Add typehints to blockchain by jenia90 · Pull Request #3149 · TheAlgorithms/Python · GitHub
Skip to content

Add typehints to blockchain - #3149

Merged
poyea merged 6 commits into
TheAlgorithms:masterfrom
jenia90:jenia90/2510_add_typehints_to_blockchain
Nov 29, 2020
Merged

Add typehints to blockchain#3149
poyea merged 6 commits into
TheAlgorithms:masterfrom
jenia90:jenia90/2510_add_typehints_to_blockchain

Conversation

@jenia90

@jenia90 jenia90 commented Oct 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

#2510 and #2128 Added type hints to the blockchain algorithms functions.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@jenia90 jenia90 changed the title #2128 Add typehints to blockchain Add typehints to blockchain Oct 15, 2020
@jenia90

jenia90 commented Oct 18, 2020

Copy link
Copy Markdown
Contributor Author

@jenia90

jenia90 commented Oct 22, 2020

Copy link
Copy Markdown
Contributor Author

@53jk1 thanks for the review! Can this be tagged for hacktoberfest?

@kbakdev

kbakdev commented Oct 22, 2020

Copy link
Copy Markdown

I am not authorized to add tags. 😄
Peace ❤️

@stale

stale Bot commented Nov 21, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Used to mark an issue or pull request stale. label Nov 21, 2020
@stale

stale Bot commented Nov 29, 2020

Copy link
Copy Markdown

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

@stale stale Bot closed this Nov 29, 2020
@poyea poyea reopened this Nov 29, 2020
@ghost

ghost commented Nov 29, 2020

Copy link
Copy Markdown

Pull Request Report

@jenia90 Hello! I'm a bot made to check all the pull request Python files. First of all, I want to say thank you for your time and interest in this project and for opening a pull request. There seems to be missing requirements in some of the Python files submitted in this pull request. Please read through the report and make the necessary changes. You can take a look at the relevant links provided after the report.

What are node paths? 🔽

The report contains headings and a checklist where the items are paths to the class/function/parameter where the requirement is missing. Node paths are double colon :: separated names and can be in any of the following format:

  • Class path: [file_name]::[class_name]
  • Function path: [file_name]::[function_name]
  • Function parameter path: [file_name]::[function_name]::[parameter_name]
  • Method path: [file_name]::[class_name]::[function_name]
  • Method parameter path: [file_name]::[class_name]::[function_name]::[parameter_name]

Following class/functions/parameters require descriptive names:

  • blockchain/chinese_remainder_theorem.py::extended_euclid::a
  • blockchain/chinese_remainder_theorem.py::extended_euclid::b
  • blockchain/chinese_remainder_theorem.py::invert_modulo::a
  • blockchain/chinese_remainder_theorem.py::invert_modulo::n
  • blockchain/diophantine_equation.py::diophantine::a
  • blockchain/diophantine_equation.py::diophantine::b
  • blockchain/diophantine_equation.py::diophantine::c
  • blockchain/diophantine_equation.py::diophantine_all_soln::a
  • blockchain/diophantine_equation.py::diophantine_all_soln::b
  • blockchain/diophantine_equation.py::diophantine_all_soln::c
  • blockchain/diophantine_equation.py::diophantine_all_soln::n
  • blockchain/diophantine_equation.py::greatest_common_divisor::a
  • blockchain/diophantine_equation.py::greatest_common_divisor::b
  • blockchain/diophantine_equation.py::extended_gcd::a
  • blockchain/diophantine_equation.py::extended_gcd::b
  • blockchain/modular_division.py::modular_division::a
  • blockchain/modular_division.py::modular_division::b
  • blockchain/modular_division.py::modular_division::n
  • blockchain/modular_division.py::invert_modulo::a
  • blockchain/modular_division.py::invert_modulo::n
  • blockchain/modular_division.py::modular_division2::a
  • blockchain/modular_division.py::modular_division2::b
  • blockchain/modular_division.py::modular_division2::n
  • blockchain/modular_division.py::extended_gcd::a
  • blockchain/modular_division.py::extended_gcd::b
  • blockchain/modular_division.py::extended_euclid::a
  • blockchain/modular_division.py::extended_euclid::b
  • blockchain/modular_division.py::greatest_common_divisor::a
  • blockchain/modular_division.py::greatest_common_divisor::b
Relevant links 🔽

@stale stale Bot removed the stale Used to mark an issue or pull request stale. label Nov 29, 2020
@ghost ghost added require descriptive names This PR needs descriptive function and/or variable names awaiting reviews This PR is ready to be reviewed labels Nov 29, 2020
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 29, 2020
@poyea

poyea commented Nov 29, 2020

Copy link
Copy Markdown
Member

Thank you for your pull request!🤩 And sorry for the delay.

@poyea
poyea merged commit 0febbd3 into TheAlgorithms:master Nov 29, 2020
@jenia90
jenia90 deleted the jenia90/2510_add_typehints_to_blockchain branch November 29, 2020 16:39
@jenia90

jenia90 commented Nov 29, 2020

Copy link
Copy Markdown
Contributor Author

@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Nov 29, 2020
dhruvmanila pushed a commit that referenced this pull request Nov 29, 2020
@poyea
Fix mypy in #3149 (#3988)
06dad4f 
* Fix mypy in #3149 
* Fix pre-commit
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@jenia90 github-actions @stokhos
Add typehints to blockchain (TheAlgorithms#3149)
d99721d 
* updating DIRECTORY.md

* updating DIRECTORY.md

* Added type hints to blockchain algorithms

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@poyea @stokhos
Fix mypy in TheAlgorithms#3149 (TheAlgorithms#3988)
2c060e9 
* Fix mypy in TheAlgorithms#3149 
* Fix pre-commit
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@jenia90 github-actions @peRFectBeliever
Add typehints to blockchain (TheAlgorithms#3149)
ff579b2 
* updating DIRECTORY.md

* updating DIRECTORY.md

* Added type hints to blockchain algorithms

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@poyea @peRFectBeliever
Fix mypy in TheAlgorithms#3149 (TheAlgorithms#3988)
4a0dd03 
* Fix mypy in TheAlgorithms#3149 
* Fix pre-commit
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@jenia90 github-actions
Add typehints to blockchain (TheAlgorithms#3149)
194481a 
* updating DIRECTORY.md

* updating DIRECTORY.md

* Added type hints to blockchain algorithms

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@poyea
Fix mypy in TheAlgorithms#3149 (TheAlgorithms#3988)
737a521 
* Fix mypy in TheAlgorithms#3149 
* Fix pre-commit
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@jenia90 github-actions @shermanhui
Add typehints to blockchain (TheAlgorithms#3149)
3977432 
* updating DIRECTORY.md

* updating DIRECTORY.md

* Added type hints to blockchain algorithms

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@poyea @shermanhui
Fix mypy in TheAlgorithms#3149 (TheAlgorithms#3988)
1691e7e 
* Fix mypy in TheAlgorithms#3149 
* Fix pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea approved these changes
+1 more reviewer
@kbakdev kbakdev kbakdev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hacktoberfest-accepted Accepted to be counted towards Hacktoberfest require descriptive names This PR needs descriptive function and/or variable names

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jenia90 @kbakdev @poyea