Hacktoberfest 2020: Conway's Game of Life by melody-notpond · Pull Request #3070 · TheAlgorithms/Python · GitHub
Skip to content

Hacktoberfest 2020: Conway's Game of Life - #3070

Merged
cclauss merged 17 commits into
TheAlgorithms:masterfrom
melody-notpond:conway
Nov 29, 2020
Merged

Hacktoberfest 2020: Conway's Game of Life#3070
cclauss merged 17 commits into
TheAlgorithms:masterfrom
melody-notpond:conway

Conversation

@melody-notpond

@melody-notpond melody-notpond commented Oct 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

Added Conway's Game of Life.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@melody-notpond melody-notpond changed the title Conway's Game of Life Hacktoberfest 2020: Conway's Game of Life Oct 16, 2020
@poyea poyea self-assigned this Oct 23, 2020
@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 23, 2020
@poyea

poyea commented Oct 23, 2020

Copy link
Copy Markdown
Member

poyea
poyea reviewed Oct 23, 2020
View reviewed changes
Comment thread cellular_automata/conways_game_of_life.py Outdated
@melody-notpond

melody-notpond commented Oct 23, 2020

Copy link
Copy Markdown
Contributor Author

Ohp I didn't realise that existed! Yeah we should probably move them both into the cellular_automata folder right?

jenra @poyea
Update cellular_automata/conways_game_of_life.py
93ae236 
Co-authored-by: John Law <johnlaw.po@gmail.com>
@cclauss

cclauss commented Oct 30, 2020

Copy link
Copy Markdown
Member

from typing import List

Fixes...

cellular_automata/conways_game_of_life.py:26:27: F821 undefined name 'List'
cellular_automata/conways_game_of_life.py:26:32: F821 undefined name 'List'
cellular_automata/conways_game_of_life.py:26:47: F821 undefined name 'List'
cellular_automata/conways_game_of_life.py:26:52: F821 undefined name 'List'

@stale

stale Bot commented Nov 29, 2020

Copy link
Copy Markdown

@stale stale Bot added the stale Used to mark an issue or pull request stale. label Nov 29, 2020
@stale stale Bot removed the stale Used to mark an issue or pull request stale. label Nov 29, 2020
@ghost ghost added awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html and removed awaiting reviews This PR is ready to be reviewed labels Nov 29, 2020
@ghost ghost added the tests are failing Do not merge until tests pass label Nov 29, 2020
@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 29, 2020
@cclauss
cclauss merged commit 5de90aa into TheAlgorithms:master Nov 29, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
jenra @poyea @stokhos
Hacktoberfest 2020: Conway's Game of Life (TheAlgorithms#3070)
4e1d6e2 
* Created conways_game_of_life.py

* Added new_generation(list[int[int]]) -> list[list[int]]

* Added glider example

* Added comments and shortened glider example

* Fixed index out of bounds error

* Added test

* Added blinker example

* Added ability to generate images

* Moved image generating code into a separate function

* Added comments

* Comment

* Reformatted file

* Formatting

* Removed glider test

* Update cellular_automata/conways_game_of_life.py

Co-authored-by: John Law <johnlaw.po@gmail.com>

* Update conways_game_of_life.py

* Update conways_game_of_life.py

Co-authored-by: John Law <johnlaw.po@gmail.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
jenra @poyea @peRFectBeliever
Hacktoberfest 2020: Conway's Game of Life (TheAlgorithms#3070)
5aff89b 
* Created conways_game_of_life.py

* Added new_generation(list[int[int]]) -> list[list[int]]

* Added glider example

* Added comments and shortened glider example

* Fixed index out of bounds error

* Added test

* Added blinker example

* Added ability to generate images

* Moved image generating code into a separate function

* Added comments

* Comment

* Reformatted file

* Formatting

* Removed glider test

* Update cellular_automata/conways_game_of_life.py

Co-authored-by: John Law <johnlaw.po@gmail.com>

* Update conways_game_of_life.py

* Update conways_game_of_life.py

Co-authored-by: John Law <johnlaw.po@gmail.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
jenra @poyea
Hacktoberfest 2020: Conway's Game of Life (TheAlgorithms#3070)
56bdd23 
* Created conways_game_of_life.py

* Added new_generation(list[int[int]]) -> list[list[int]]

* Added glider example

* Added comments and shortened glider example

* Fixed index out of bounds error

* Added test

* Added blinker example

* Added ability to generate images

* Moved image generating code into a separate function

* Added comments

* Comment

* Reformatted file

* Formatting

* Removed glider test

* Update cellular_automata/conways_game_of_life.py

Co-authored-by: John Law <johnlaw.po@gmail.com>

* Update conways_game_of_life.py

* Update conways_game_of_life.py

Co-authored-by: John Law <johnlaw.po@gmail.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
jenra @poyea @shermanhui
Hacktoberfest 2020: Conway's Game of Life (TheAlgorithms#3070)
ce6e919 
* Created conways_game_of_life.py

* Added new_generation(list[int[int]]) -> list[list[int]]

* Added glider example

* Added comments and shortened glider example

* Fixed index out of bounds error

* Added test

* Added blinker example

* Added ability to generate images

* Moved image generating code into a separate function

* Added comments

* Comment

* Reformatted file

* Formatting

* Removed glider test

* Update cellular_automata/conways_game_of_life.py

Co-authored-by: John Law <johnlaw.po@gmail.com>

* Update conways_game_of_life.py

* Update conways_game_of_life.py

Co-authored-by: John Law <johnlaw.po@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea left review comments
@cclauss cclauss cclauss approved these changes

Assignees

@poyea poyea

Labels

hacktoberfest-accepted Accepted to be counted towards Hacktoberfest require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@melody-notpond @poyea @cclauss