Hacktoberfest 2020 - Add typehints and default input for project_euler/problem_25 by nstoik · Pull Request #2901 · TheAlgorithms/Python · GitHub
Skip to content

Hacktoberfest 2020 - Add typehints and default input for project_euler/problem_25 - #2901

Merged
dhruvmanila merged 8 commits into
TheAlgorithms:masterfrom
nstoik:master
Oct 7, 2020
Merged

Hacktoberfest 2020 - Add typehints and default input for project_euler/problem_25#2901
dhruvmanila merged 8 commits into
TheAlgorithms:masterfrom
nstoik:master

Conversation

@nstoik

@nstoik nstoik commented Oct 6, 2020

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Related: #2786

@nstoik

nstoik commented Oct 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Kush1101
Kush1101 reviewed Oct 6, 2020
View reviewed changes
Comment thread project_euler/problem_25/sol1.py
dhruvmanila
dhruvmanila reviewed Oct 6, 2020
View reviewed changes
Comment thread project_euler/problem_25/sol1.py
@dhruvmanila dhruvmanila added awaiting changes A maintainer has requested changes to this PR hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 6, 2020
dhruvmanila
dhruvmanila approved these changes Oct 7, 2020
View reviewed changes

@dhruvmanila dhruvmanila left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@dhruvmanila
dhruvmanila merged commit 4d4ce40 into TheAlgorithms:master Oct 7, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@nstoik @stokhos
Add typehints and default input for project_euler/problem_25 (TheAlgo…
b6d5012 
…rithms#2901)

* add typehints and docstrings

* add typehint and default value

* add typehint and default value. Removed unused variable.

* do not modifiy the given solution

* add doctests

* update sol1 after running black

* add typehint, docstring, and doctest

* update sol2 after running black
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@nstoik
Add typehints and default input for project_euler/problem_25 (TheAlgo…
7084994 
…rithms#2901)

* add typehints and docstrings

* add typehint and default value

* add typehint and default value. Removed unused variable.

* do not modifiy the given solution

* add doctests

* update sol1 after running black

* add typehint, docstring, and doctest

* update sol2 after running black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kush1101 Kush1101 Kush1101 left review comments
@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees

No one assigned

Labels

awaiting changes A maintainer has requested changes to this PR hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nstoik @Kush1101 @dhruvmanila