{{ message }}
Add GitHub action for pre-commit - #2515
Merged
Merged
Conversation
Member
Author
- Remove executable bit from files without shebang. I checked those file and it was not needed. - Fix with black
Member
Author
|
I think the name of the file should be lint, what do you think? @cclauss |
cclauss
reviewed
Sep 30, 2020
cclauss
requested changes
Sep 30, 2020
cclauss
left a comment
cclauss
left a comment
Member
There was a problem hiding this comment.
Simplifying by always using the latest and greatest Python and by dropping names that are less self-documenting than the commands that they run.
Member
|
Why not just add the shebang instead of removing the execution bit? |
Member
I think the current name is good enough. The script runs pre-commit so it should be called pre-commit. |
Co-authored-by: Christian Clauss <cclauss@me.com>
Member
Author
cclauss
approved these changes
Sep 30, 2020
14 tasks
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Add GitHub action file for pre-commit * Fix errors exposed by pre-commit hook: - Remove executable bit from files without shebang. I checked those file and it was not needed. - Fix with black * Apply suggestions from code review Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Christian Clauss <cclauss@me.com>
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
* Add GitHub action file for pre-commit * Fix errors exposed by pre-commit hook: - Remove executable bit from files without shebang. I checked those file and it was not needed. - Fix with black * Apply suggestions from code review Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #2511
As mentioned in #2511 (comment)
Describe your change:
Checklist: