{{ message }}
Corrected filename and include static types - #2440
Merged
Merged
Conversation
- The name of the file is now compliant with python naming conventions - Add static type as stated in contributing guidelines
Contributor
cclauss
reviewed
Sep 16, 2020
cclauss
reviewed
Sep 16, 2020
cclauss
reviewed
Sep 16, 2020
cclauss
reviewed
Sep 16, 2020
cclauss
reviewed
Sep 16, 2020
| >>> print(binary_search(test_list, 3)) | ||
| False | ||
| >>> print(binary_search(test_list, 13)) | ||
| True |
Member
There was a problem hiding this comment.
Please add tests for negative integers, floats, repeated numbers, letters, empty list, single element list.
cclauss
reviewed
Sep 16, 2020
cclauss
reviewed
Sep 16, 2020
cclauss
reviewed
Sep 16, 2020
Contributor
Author
- Delete documentation line to run doctests - Delete type hints for variables that comes from functions Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
approved these changes
Sep 17, 2020
cclauss
left a comment
cclauss
left a comment
Member
There was a problem hiding this comment.
LGTM. It would be easier to review as two PRs. One that changed the filename and the other that changed the file contents.
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Corrected name and include static types
- The name of the file is now compliant with python naming conventions
- Add static type as stated in contributing guidelines
* Apply suggestions from code review
- Delete documentation line to run doctests
- Delete type hints for variables that comes from functions
Co-authored-by: Christian Clauss <cclauss@me.com>
* Add edge cases tests.
* print(f"{target} was {not_str}found in {sequence}")
Co-authored-by: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuing in line with #2128.
My first time contributing code to open source so criticism is encouraged.
Describe your change:
Checklist: