Adding type hints to RedBlackTree by kanthuc · Pull Request #2371 · TheAlgorithms/Python · GitHub
Skip to content

Adding type hints to RedBlackTree - #2371

Merged
cclauss merged 2 commits into
TheAlgorithms:masterfrom
kanthuc:red_black_tree.py
Aug 30, 2020
Merged

Adding type hints to RedBlackTree#2371
cclauss merged 2 commits into
TheAlgorithms:masterfrom
kanthuc:red_black_tree.py

Conversation

@kanthuc

@kanthuc kanthuc commented Aug 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy

TravisBuddy commented Aug 29, 2020

Copy link
Copy Markdown

cclauss
cclauss approved these changes Aug 30, 2020
View reviewed changes

@cclauss cclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cclauss
cclauss merged commit 472f63e into TheAlgorithms:master Aug 30, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@kanthuc @stokhos
Adding type hints to RedBlackTree (TheAlgorithms#2371)
2e488d2 
* redblacktree type hints

* fixed type hints to pass flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kanthuc @TravisBuddy @cclauss