{{ message }}
added type hints and doctests to arithmetic_analysis/intersection.py - #2242
Merged
Conversation
Contributor
Author
swapnanildutta
approved these changes
Jul 31, 2020
swapnanildutta
approved these changes
Jul 31, 2020
itsvinayak
approved these changes
Aug 1, 2020
Member
|
@cclauss please have a look |
cclauss
approved these changes
Aug 1, 2020
cclauss
left a comment
cclauss
left a comment
Member
There was a problem hiding this comment.
The variable names (x0, x1, x_n, x_n1, x_n2), etc. make my head spin but these changes look good to me.
Contributor
Author
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuing #2128
Describe your change:
Checklist: