Rename shortest_job_first_algorithm.py to shortest_job_first.py by cclauss · Pull Request #2164 · TheAlgorithms/Python · GitHub
Skip to content

Rename shortest_job_first_algorithm.py to shortest_job_first.py - #2164

Merged
itsvinayak merged 3 commits into
masterfrom
cclauss-patch-1
Jul 3, 2020
Merged

Rename shortest_job_first_algorithm.py to shortest_job_first.py#2164
itsvinayak merged 3 commits into
masterfrom
cclauss-patch-1

Conversation

@cclauss

@cclauss cclauss commented Jul 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss
cclauss requested review from itsvinayak, l3str4nge and poyea July 3, 2020 13:22
@itsvinayak
itsvinayak merged commit 2c98dce into master Jul 3, 2020
@cclauss
cclauss deleted the cclauss-patch-1 branch July 27, 2020 18:11
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@cclauss github-actions @stokhos
Rename shortest_job_first_algorithm.py to shortest_job_first.py (TheA…
0024a23 
…lgorithms#2164)

* Rename shortest_job_first_algorithm.py to shortest_job_first.py

* updating DIRECTORY.md

* Minor tweek to round_robin.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsvinayak itsvinayak itsvinayak approved these changes
@l3str4nge l3str4nge Awaiting requested review from l3str4nge
@poyea poyea Awaiting requested review from poyea
+1 more reviewer
@ruppysuppy ruppysuppy ruppysuppy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cclauss @itsvinayak @ruppysuppy