Add lempel ziv compression by iko1133 · Pull Request #2107 · TheAlgorithms/Python · GitHub
Skip to content

Add lempel ziv compression - #2107

Merged
cclauss merged 5 commits into
TheAlgorithms:masterfrom
iko1133:add-lempel-ziv-compression
Jun 17, 2020
Merged

Add lempel ziv compression#2107
cclauss merged 5 commits into
TheAlgorithms:masterfrom
iko1133:add-lempel-ziv-compression

Conversation

@iko1133

@iko1133 iko1133 commented Jun 12, 2020

Copy link
Copy Markdown
Contributor
  • Implemented lempel-ziv-welch compression/decompression algorithm

@TravisBuddy

TravisBuddy commented Jun 12, 2020

Copy link
Copy Markdown

@TravisBuddy

TravisBuddy commented Jun 12, 2020

Copy link
Copy Markdown

Hey @iko1133,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: dc979620-acc8-11ea-8245-836d9da6cb4c

@iko1133

iko1133 commented Jun 12, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi.
It seems the earlier pushed file ("decimal_to_any.py") has broken the build.
What should I do in this case?

8.64s$ flake8 --ignore=E203,W503 --max-complexity=25 --max-line-length=120 --statistics --count .

./conversions/decimal_to_any.py:70:25: E127 continuation line over-indented for visual indent

E127 continuation line over-indented for visual indent

cclauss
cclauss requested changes Jun 17, 2020
View reviewed changes

@cclauss cclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type hints? Doctests? See CONTRIBUTING.md.

Comment thread compression/lempel_ziv.py Outdated
Comment thread compression/lempel_ziv.py Outdated
Comment thread compression/lempel_ziv.py Outdated
Comment thread compression/lempel_ziv.py Outdated
Comment thread compression/lempel_ziv.py Outdated
Comment thread compression/lempel_ziv_decompress.py Outdated
Comment thread compression/lempel_ziv_decompress.py Outdated
Comment thread compression/lempel_ziv_decompress.py Outdated
Comment thread compression/lempel_ziv_decompress.py Outdated
Comment thread compression/lempel_ziv_decompress.py Outdated
@cclauss cclauss added require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Jun 17, 2020
@TravisBuddy

TravisBuddy commented Jun 17, 2020

Copy link
Copy Markdown

Hey @iko1133,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 432509b0-b0c8-11ea-b9a3-b9754cbad7e4

@cclauss

cclauss commented Jun 17, 2020

Copy link
Copy Markdown
Member

cclauss
cclauss reviewed Jun 17, 2020
View reviewed changes
Comment thread compression/lempel_ziv.py
cclauss
cclauss reviewed Jun 17, 2020
View reviewed changes
Comment thread compression/lempel_ziv_decompress.py
@cclauss
cclauss merged commit 19b713a into TheAlgorithms:master Jun 17, 2020
@cclauss cclauss removed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Jun 17, 2020
@iko1133
iko1133 deleted the add-lempel-ziv-compression branch June 17, 2020 19:25
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@iko1133 @stokhos
Add lempel ziv compression (TheAlgorithms#2107)
ba6a854 
* Added lempel-ziv compression algorithm implementation

* Added lempel-ziv decompression algorithm implementation

* Reformatted lempel-ziv compress/decompress files using black

* Added type hints and some other modifications (Doctests coming up)

* Shortened several lines to comply with the standards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iko1133 @TravisBuddy @cclauss