Gale Shapley Algorithm - #2100
Conversation
Implementation of a Nobel prize-winning algorithm that determines a stable matching in a bipartite graph.
l3str4nge
left a comment
There was a problem hiding this comment.
Please flake8 --ignore=E203,W503 --max-complexity=25 --max-line-length=120 --statistics --count . on your local machine and fix errors.
Co-authored-by: Christian Clauss <cclauss@me.com>
|
Hey @akashvshroff, TravisCI finished with status TravisBuddy Request Identifier: 3875c110-b633-11ea-aaf6-456b40a357ff |
I think it should be alright now? Thanks. |
|
Hey @akashvshroff, TravisCI finished with status TravisBuddy Request Identifier: bf289ae0-b636-11ea-aaf6-456b40a357ff |
|
I read the log, it said |
When I do it, it says 0 and indicates there are no errors - did you try it on the code as part of my latest commit? Thanks. |
|
psf/black and other formatters might be reluctant to modify text that is inside a triple quoted string but flake8 will still flag that those lines as having trailing whitespace. If that is the case then manual edits may be required. |
|
I know this is a bit of a chore but... I do not think that we should base an algorithm on the premise that |
I've made the necessary changes and manually ensured that there is no trailing whitespace in the program, I hope it is alright now! Thanks. |
|
Hey @akashvshroff, TravisCI finished with status TravisBuddy Request Identifier: 73f20c50-bde3-11ea-a595-8f8781864445 |
cclauss
left a comment
There was a problem hiding this comment.
Just a few minor changes and then we can land this one.
|
./graphs/gale_shapley_bigraph.py:30:89: E501 line too long (90 > 88 characters) |
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
|
Hey @akashvshroff, TravisCI finished with status TravisBuddy Request Identifier: 56e77eb0-be7e-11ea-b6c3-5fc2c9c22d2c |
|
I hope I've edited everything as required! |
* Gale Shapley Algorithm Implementation of a Nobel prize-winning algorithm that determines a stable matching in a bipartite graph. * Update graphs/gale_shapley_bigraph.py Co-authored-by: Christian Clauss <cclauss@me.com> * Fixed some flake8 issues. * Updated it to donors and recipients * description changes Co-authored-by: Christian Clauss <cclauss@me.com> * description changes Co-authored-by: Christian Clauss <cclauss@me.com> * description changes Co-authored-by: Christian Clauss <cclauss@me.com> * Edited the line lengths * Update gale_shapley_bigraph.py * Update gale_shapley_bigraph.py Co-authored-by: Christian Clauss <cclauss@me.com>

Implementation of a Nobel prize-winning algorithm that determines a stable matching in a bipartite graph.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.