added Boruvka's MST algorithm by nitishabharathi · Pull Request #2026 · TheAlgorithms/Python · GitHub
Skip to content

added Boruvka's MST algorithm - #2026

Merged
cclauss merged 14 commits into
TheAlgorithms:masterfrom
nitishabharathi:master
May 25, 2020
Merged

cclauss merged 14 commits into
TheAlgorithms:masterfrom
nitishabharathi:master

Conversation

@nitishabharathi

@nitishabharathi nitishabharathi commented May 22, 2020

Copy link
Copy Markdown
Contributor

Describe your change:

Added Boruvka's Minimum Spanning Tree Algorithm

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@poyea poyea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the code! Could you please also add some doctests and typing for your functions and classes, as stated in the CONTRIBUTION.md? It seems that the build failure can be fixed by enabling GitHub Actions in your fork setting.

@poyea

poyea commented May 22, 2020

Copy link
Copy Markdown
Member

@cclauss cclauss added tests are failing Do not merge until tests pass require tests Tests [doctest/unittest/pytest] are required labels May 23, 2020
@ghost

ghost commented May 25, 2020

Copy link
Copy Markdown

Please check my small code my respiratory "My time saver" give a hand to raise new programmer it completely written with if you can just execute and check

@cclauss

cclauss commented May 25, 2020

Copy link
Copy Markdown
Member

@cclauss cclauss removed require tests Tests [doctest/unittest/pytest] are required tests are failing Do not merge until tests pass labels May 25, 2020
@nitishabharathi
nitishabharathi requested a review from poyea May 25, 2020 12:04

@poyea poyea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@cclauss
cclauss merged commit 0e61906 into TheAlgorithms:master May 25, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* added Boruvka's MST algorithm

* Add files via upload

* fixup! Format Python code with psf/black push

* Updated Boruvka with doctest

* updating DIRECTORY.md

* Update minimum_spanning_tree_boruvka.py

* No blank line in doctest

* <BLANKLINE>

* Avoid mutable default values

https://docs.python-guide.org/writing/gotchas/

* Update minimum_spanning_tree_boruvka.py

* Avoid mutable default values

* fixup! Format Python code with psf/black push

* Update minimum_spanning_tree_boruvka.py

* Update minimum_spanning_tree_boruvka.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants