improved prime numbers implementation by nikolasvargas · Pull Request #1606 · TheAlgorithms/Python · GitHub
Skip to content

improved prime numbers implementation #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cclauss merged 16 commits into from
Dec 7, 2019
Merged

improved prime numbers implementation #1606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
66db8d7
improved prime numbers implementation
nikolasvargas Dec 2, 2019
4f1cb27
fixup! Format Python code with psf/black push
Dec 2, 2019
9a1befa
fix type hint
nikolasvargas Dec 2, 2019
7e892bb
Merge branch 'maths' of github.com:nikolasvargas/Python into maths
nikolasvargas Dec 2, 2019
f2d7c5e
fixup! Format Python code with psf/black push
Dec 2, 2019
369a169
fix doctests
nikolasvargas Dec 3, 2019
7c1f27e
Merge branch 'maths' of github.com:nikolasvargas/Python into maths
nikolasvargas Dec 3, 2019
284832b
updating DIRECTORY.md
Dec 3, 2019
6c1bd33
added prime tests with negative numbers
nikolasvargas Dec 3, 2019
c60a71b
Merge branch 'maths' of github.com:nikolasvargas/Python into maths
nikolasvargas Dec 3, 2019
41ae8bc
Merge branch 'master' of https://github.com/TheAlgorithms/Python into…
nikolasvargas Dec 6, 2019
2a539aa
using for instead filter
nikolasvargas Dec 6, 2019
609fb05
updating DIRECTORY.md
Dec 6, 2019
b5f294b
Remove unused typing.List
cclauss Dec 7, 2019
fea8077
Remove tab indentation
cclauss Dec 7, 2019
266ad42
print("Sorted order is:", " ".join(a))
cclauss Dec 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion DIRECTORY.md
View file
Open in desktop
3 changes: 2 additions & 1 deletion data_structures/data_structures/heap/heap_generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ def _swap(self, i, j):
"""Performs changes required for swapping two elements in the heap"""
# First update the indexes of the items in index map.
self.pos_map[self.arr[i][0]], self.pos_map[self.arr[j][0]] = (
self.pos_map[self.arr[j][0]], self.pos_map[self.arr[i][0]]
self.pos_map[self.arr[j][0]],
self.pos_map[self.arr[i][0]],
)
# Then swap the items in the list.
self.arr[i], self.arr[j] = self.arr[j], self.arr[i]
Expand Down
8 changes: 4 additions & 4 deletions digital_image_processing/index_calculation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,10 @@ def calculation(

def ARVI2(self):
"""
Atmospherically Resistant Vegetation Index 2
https://www.indexdatabase.de/db/i-single.php?id=396
:return: index
−0.18+1.17*(self.nir−self.red)/(self.nir+self.red)
Atmospherically Resistant Vegetation Index 2
https://www.indexdatabase.de/db/i-single.php?id=396
:return: index
−0.18+1.17*(self.nir−self.red)/(self.nir+self.red)
"""
return -0.18 + (1.17 * ((self.nir - self.red) / (self.nir + self.red)))

Expand Down
44 changes: 25 additions & 19 deletions maths/prime_numbers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,34 @@
from typing import List
from typing import Generator


def primes(max: int) -> List[int]:
def primes(max: int) -> Generator[int, None, None]:
"""
Return a list of all primes numbers up to max.
>>> primes(10)
[2, 3, 5, 7]
>>> primes(11)
[2, 3, 5, 7, 11]
>>> primes(25)
>>> list(primes(0))
[]
>>> list(primes(-1))
[]
>>> list(primes(-10))
[]
>>> list(primes(25))
[2, 3, 5, 7, 11, 13, 17, 19, 23]
>>> primes(1_000_000)[-1]
999983
>>> list(primes(11))
[2, 3, 5, 7, 11]
>>> list(primes(33))
[2, 3, 5, 7, 11, 13, 17, 19, 23, 29, 31]
>>> list(primes(10000))[-1]
9973
"""
max += 1
numbers = [False] * max
ret = []
for i in range(2, max):
if not numbers[i]:
for j in range(i, max, i):
numbers[j] = True
ret.append(i)
return ret
numbers: Generator = (i for i in range(1, (max + 1)))
for i in (n for n in numbers if n > 1):
for j in range(2, i):
if (i % j) == 0:
break
else:
yield i


if __name__ == "__main__":
print(primes(int(input("Calculate primes up to:\n>> "))))
number = int(input("Calculate primes up to:\n>> ").strip())
for ret in primes(number):
print(ret)
5 changes: 3 additions & 2 deletions sorts/pigeonhole_sort.py
View file
Open in desktop