{{ message }}
Logical Implementation of Shor Algorithm - #12317
Open
joelkurien wants to merge 8 commits into
Open
joelkurien wants to merge 8 commits into
joelkurien wants to merge 8 commits into
Conversation
for more information, see https://pre-commit.ci
priya-sundaram-dev
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the pure-Python Shor implementation @joelkurien — keeping it dependency-free is a good fit for the collection. A few issues to address before merge:
- Module docstring placement. The triple-quoted description sits after
import math/import random, so Python doesn't treat it as the module docstring. Move it to the very top of the file, above the imports. - Import-time side effects.
shor = Shor()andprint(shor.shor_algorithm(15))run at module top level, so they execute on import (during test collection and DIRECTORY generation). Please move them underif __name__ == "__main__":, and addimport doctest; doctest.testmod()there. - Re-seeding inside the loop (bug).
shor_algorithmcallsrandom.seed(0)insidewhile True, so every iteration draws the samenum; if that candidate never yields a factor, the loop spins forever. Seed once before the loop (or not at all) and letnumvary across iterations. - Minor: with the loop restructured, make sure the annotated
-> tuple[int, int]return always holds (no implicitNonefall-through).
Type hints and the period_find doctest are good — the above are the main blockers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Describe your change:
Checklist: