Update binary_to_decimal.py by USP-2024 · Pull Request #11919 · TheAlgorithms/Python · GitHub
Skip to content

Update binary_to_decimal.py - #11919

Open
USP-2024 wants to merge 2 commits into
TheAlgorithms:masterfrom
USP-2024:BCD-to-Grey
Open

USP-2024 wants to merge 2 commits into
TheAlgorithms:masterfrom
USP-2024:BCD-to-Grey

Conversation

@USP-2024

@USP-2024 USP-2024 commented Oct 9, 2024

Copy link
Copy Markdown

added a python code for BCD to Gray conversion

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

USP-2024 and others added 2 commits October 9, 2024 15:22
added a python code for BCD to Gray conversion
@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Oct 9, 2024

@saahil-mahato saahil-mahato Oct 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can simplify the conversion by using bit wise operators like this:
gray = bcd ^ (bcd >> 1)
return format(gray, '04b')

@USP-2024 USP-2024 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The can work well by using bit wise operators also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants