Add doctests in all functions in basic_string.py by KelvinPuyam · Pull Request #11374 · TheAlgorithms/Python · GitHub
Skip to content

Add doctests in all functions in basic_string.py - #11374

Merged
cclauss merged 6 commits into
TheAlgorithms:masterfrom
KelvinPuyam:add-doctests-basic-string
Apr 20, 2024
Merged

Add doctests in all functions in basic_string.py#11374
cclauss merged 6 commits into
TheAlgorithms:masterfrom
KelvinPuyam:add-doctests-basic-string

Conversation

@KelvinPuyam

@KelvinPuyam KelvinPuyam commented Apr 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@KelvinPuyam

KelvinPuyam commented Apr 20, 2024

Copy link
Copy Markdown
Contributor Author

cclauss
cclauss reviewed Apr 20, 2024
View reviewed changes
Comment thread genetic_algorithm/basic_string.py Outdated
cclauss
cclauss reviewed Apr 20, 2024
View reviewed changes
Comment thread genetic_algorithm/basic_string.py Outdated
@algorithms-keeper algorithms-keeper Bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Apr 20, 2024
@KelvinPuyam

KelvinPuyam commented Apr 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@KelvinPuyam
KelvinPuyam requested a review from cclauss April 20, 2024 08:12
cclauss
cclauss reviewed Apr 20, 2024
View reviewed changes
Comment thread genetic_algorithm/basic_string.py Outdated
@cclauss
cclauss enabled auto-merge (squash) April 20, 2024 10:41
@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Apr 20, 2024
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Apr 20, 2024
cclauss
cclauss approved these changes Apr 20, 2024
View reviewed changes

@cclauss cclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock and roll!!

@cclauss
cclauss merged commit 4259348 into TheAlgorithms:master Apr 20, 2024
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Apr 20, 2024
@KelvinPuyam
KelvinPuyam deleted the add-doctests-basic-string branch April 20, 2024 10:53
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KelvinPuyam @cclauss