Fixes bugs in graphs/dijkstra_algorithm.py by Kpraful · Pull Request #10092 · TheAlgorithms/Python · GitHub
Skip to content

Fixes bugs in graphs/dijkstra_algorithm.py - #10092

Merged
MaximSmolskiy merged 6 commits into
TheAlgorithms:masterfrom
Kpraful:Adds-doctest-in-deapth_first_search_2
Aug 27, 2025
Merged

Fixes bugs in graphs/dijkstra_algorithm.py#10092
MaximSmolskiy merged 6 commits into
TheAlgorithms:masterfrom
Kpraful:Adds-doctest-in-deapth_first_search_2

Conversation

@Kpraful

@Kpraful Kpraful commented Oct 8, 2023

Copy link
Copy Markdown
Contributor

Describe your change:

There was a bug in PriorityQueue class due to which extract_min function was giving wrong output, hence fixed it.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 8, 2023
praful-katare
praful-katare approved these changes Oct 9, 2023
View reviewed changes

@praful-katare praful-katare left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes, please close the PR.

@cclauss

cclauss commented Oct 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@Kpraful

Kpraful commented Oct 16, 2023

Copy link
Copy Markdown
Contributor Author

If I add doctests in the previous algorithm then it will fail, therefore I was first trying to fix the code and then add doctests to it.
What should I do now? Create another PR add doctests and fix the bug in the same PR?

@cclauss

cclauss commented Oct 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Aug 27, 2025
@MaximSmolskiy MaximSmolskiy changed the title Fixes bug in PriorityQueue Algorithm; Fixes syntax in code for array. Fixes bugs in graphs/dijkstra_algorithm.py Aug 27, 2025
@algorithms-keeper algorithms-keeper Bot removed awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Aug 27, 2025
@MaximSmolskiy
MaximSmolskiy merged commit 54aa73f into TheAlgorithms:master Aug 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaximSmolskiy MaximSmolskiy MaximSmolskiy approved these changes
+1 more reviewer
@praful-katare praful-katare praful-katare approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kpraful @cclauss @MaximSmolskiy @praful-katare