Add weight and length conversion functions by haj8110 · Pull Request #183 · TheAlgorithms/PHP · GitHub
Skip to content

Add weight and length conversion functions - #183

Open
haj8110 wants to merge 4 commits into
TheAlgorithms:masterfrom
haj8110:new-feature-branch
Open

haj8110 wants to merge 4 commits into
TheAlgorithms:masterfrom
haj8110:new-feature-branch

Conversation

@haj8110

@haj8110 haj8110 commented Mar 18, 2025

Copy link
Copy Markdown

No description provided.

@darwinz darwinz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Please run the linter by running vendor/bin/phpcs -n. There are a few linter errors that need to be addressed. Thanks!

Comment thread Conversions/Lengthconversions.php
Comment thread Conversions/Lengthconversions.php Outdated
Co-authored-by: Brandon Johnson <bbj1979@gmail.com>
@darwinz

darwinz commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

@darwinz

darwinz commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

… code style

- Updated class definitions to follow PSR standards by adding opening braces on the same line.
- Adjusted method definitions to align with coding conventions.
- Ensured consistent formatting and spacing throughout the conversion methods.

@haj8110 haj8110 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update and remove the error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants