Add Baconian Cipher by IcarusTheFly · Pull Request #1416 · TheAlgorithms/JavaScript · GitHub
Skip to content

Add Baconian Cipher - #1416

Closed
IcarusTheFly wants to merge 2 commits into
TheAlgorithms:masterfrom
IcarusTheFly:BaconianCipher
Closed

IcarusTheFly wants to merge 2 commits into
TheAlgorithms:masterfrom
IcarusTheFly:BaconianCipher

Conversation

@IcarusTheFly

@IcarusTheFly IcarusTheFly commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@appgurueu

Copy link
Copy Markdown
Collaborator

@IcarusTheFly

Copy link
Copy Markdown
Contributor Author

What makes a simple substitution cipher algorithmically interesting?

That should have been a question for this PR: TheAlgorithms/Python#5251
I saw the algorithm is already in the site in Python and though about adding the JS version :)

I think this one is useful because someone studying ciphers might want to see the implementation in JavaScript.

@appgurueu

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants