Added base conversions.#17
Conversation
mrdjohnson
left a comment
mrdjohnson
left a comment
There was a problem hiding this comment.
Hopefully marked some compile and runtime errors. Also the code style here is based on C#, would suggest following the Java style guide (or just using Jetbrains' IDEA's auto formatting).
| { | ||
| int array[]=new int[6]; | ||
| int n; | ||
| int array[]=new int[n]; |
There was a problem hiding this comment.
"n" has no value here, this will break
| Scanner input=new Scanner(System.in); | ||
|
|
||
| System.out.println("Enter length of array:"); | ||
| n=sc.nextInt(); |
There was a problem hiding this comment.
now that n has a value we can initialize the "array" variable down here
| int a[]={'A','B','C','D','E','F'}; | ||
| n=sc.nextInt(); | ||
| k=n; | ||
| while(k!=0) |
There was a problem hiding this comment.
infinite while loop, the value of k is never modified
AnupKumarPanwar
left a comment
AnupKumarPanwar
left a comment
There was a problem hiding this comment.
The statement number 8 needs to be placed after 11th statement.
|
Made the requisite changes. Kindly check. |
|
Can the admins and reviewers please look into the updations ? Thank you. @dynamitechetan @DocJava @AnupKumarPanwar |
|
Looks fine, I would suggest using readable variable names (instead of i k n j or other random letters). |
|
Sure. Should I change the variable names for these codes as well, or should I keep this pointer in mind next time onwards ? @DocJava |
|
That is up to you, the coder. (I vote to change it now though) |
|
@shivhek25 Please resolve the conflicts. |
|
I have already made all the changes. Could you please specify which conflicts are to be resolved ? |
|
There are conflicts in BubbleSort.java |
|
The resolve conflicts is deactivated so I followed the instructions on how to resolve the error using cmd. After having done those, the file is still under conflict. |
6 participants
No description provided.