{{ message }}
Repository navigation
dpl: respect oriented fixed macro footprints - #11856
Open
jinchuntan wants to merge 2 commits into
Open
jinchuntan wants to merge 2 commits into
jinchuntan wants to merge 2 commits into
Conversation
Build fixed blockages from the oriented bounding box and covering grid cells. Keep their actual position when the footprint crosses the core boundary. Add orientation, boundary and Nangate45 GCD placement coverage. Fixes The-OpenROAD-Project#11735 Signed-off-by: Nigel Tan <nigeltanjc@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates NegotiationLegalizer::initFromDb to correctly handle fixed cells by covering their oriented footprint at their actual location, rather than snapping and clamping them like non-fixed cells. It also adds comprehensive unit tests (FixedMacroFootprintTest and GcdPlacementTest) to verify legalization behavior with various macro orientations, and updates the build configuration to include the necessary test data. There are no review comments to address, and I have no additional feedback to provide.
Update the expected logs for the corrected fixed macro footprints. Check placement legality in both obstruction2 tests and let placement errors fail the tests. Signed-off-by: Nigel Tan <nigeltanjc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the oriented bounding box and covering grid cells for fixed instances in the negotiation legalizer.
Update the affected regression logs and check placement legality in the Tcl and Python obstruction tests.
Type of Change
Impact
Legal cells beside rotated macros stay in place. Footprints crossing the core boundary keep their actual position.
Verification
//src/dpl/test/...pass including all 43 C++ tests.Local validation used the pinned LLVM dependency with archive ownership restoration disabled for this container. The full OpenROAD regression suite and ORFS flows were not run locally.
Related Issues
Fixes #11735
Prepared with Codex.