Update AbstractObjectParser.java by zhoulingfengofcd · Pull Request #119 · Tencent/APIJSON · GitHub
Skip to content

Update AbstractObjectParser.java#119

Merged
TommyLemon merged 2 commits intoTencent:masterfrom
zhoulingfengofcd:zhoulingfengofcd-patch-1
Feb 27, 2020
Merged

Update AbstractObjectParser.java#119
TommyLemon merged 2 commits intoTencent:masterfrom
zhoulingfengofcd:zhoulingfengofcd-patch-1

Conversation

@zhoulingfengofcd
Copy link
Copy Markdown
Contributor

POST(新增)支持批量,批量事务问题处理方式:全部成功,则成功,只要一条失败,全部失败

POST(新增)支持批量,批量事务问题处理方式:全部成功,则成功,只要一条失败,全部失败
@TommyLemon
Copy link
Copy Markdown
Collaborator

@TommyLemon TommyLemon merged commit 1d2d25f into Tencent:master Feb 27, 2020
Copy link
Copy Markdown
Collaborator

@TommyLemon TommyLemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}
}
else if (method == PUT && value instanceof JSONArray
} else if (value instanceof JSONArray && method == POST &&
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POST 未被 import 进来直接使用,编译报错

JSONObject before = (JSONObject)response.get(key);
if(result.get("code").equals(200)){
if(before!=null){
before.put("count",before.getInteger("count")+result.getInteger("count"));
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"count" 已有 JSONRequst.KEY_COUNT 常量,建议替换

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议根据 JSONResponse.KEY_CODE 及 JSONResponse.KEY_MSG 改为更准确的 Exeption,方便排查错误

@zhoulingfengofcd zhoulingfengofcd deleted the zhoulingfengofcd-patch-1 branch March 1, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants