[BUG] Role model updates · Issue #61 · Tech-With-Tim/API · GitHub
Skip to content

[BUG] Role model updates #61

Open

Description

@takos22

The UpdateRoleBody and NewRoleBody have some issues and need some updates, here are the needed updates:

  1. The UpdateRoleBody.name has a max_length of 64 instead of the 32 in NewRoleBody.name.

  2. The NewRoleBody.color and UpdateRoleBody.color could use a pydantic.Color field instead of the current int field.

    color: Optional[int] = Field(None, le=0xFFFFFF, ge=0)

Activity

  1. added this to the Initial Release milestone on Sep 15, 2021
  2. linked a pull request that will close this issueUpdate role models (fix issue #61) #63on Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions