Feature 21 add toggle method by dstutemann · Pull Request #121 · Teamwork/node-auto-launch · GitHub
Skip to content

Feature 21 add toggle method - #121

Open
dstutemann wants to merge 2 commits into
Teamwork:masterfrom
dstutemann:feature-21-add-toggle-method
Open

dstutemann wants to merge 2 commits into
Teamwork:masterfrom
dstutemann:feature-21-add-toggle-method

Conversation

@dstutemann

Copy link
Copy Markdown

Target Platform

  • Windows
  • Mac
  • Linux

What Problem does this solve?

This adds functionality requested in issue #21

Could it break existing functionality

No, this just adds a new function and does not modify existing functions

Additional Info

I have tested this using a test project on Windows and macOS. Somebody should test it on Linux as I am not a Linux user.

@Oxalin

Oxalin commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

@dstutemann

Copy link
Copy Markdown
Author

Hi @Oxalin,
I added the optional parameter value as it was requested in the issue. If you don't specify a parameter the function will toggle the state to the opposite, if you specify a parameter it will toggle to the desired state.

Unfortunately I can't see the 6.x.x branch.

I took the issue because it was marked as "good first issue". Feel free to close this PR if you decide that the feature isn't needed anymore.

@Oxalin

Oxalin commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

I think the feature would simplify some logic that many apps need to implement.

Under Code > Tags, the latest entry is 6.0.0-rc1.

@Oxalin Oxalin added this to the 6.1.0 milestone Apr 6, 2024
@Oxalin

Oxalin commented Apr 6, 2024

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants