Have different message when a closed PR is merged or not by toffentoffen · Pull Request #26 · Teamwork/github-sync · GitHub
Skip to content

Have different message when a closed PR is merged or not #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelbemartin merged 3 commits into from
Oct 1, 2020
Merged

Have different message when a closed PR is merged or not #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d25487a
Move merged key to the correct position inside pull_request
Sep 30, 2020
cac77fe
Have different message when a closed PR is merged or not
Sep 30, 2020
93e77b4
Add missing file containing the get_pr_merged function
Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/github.sh
View file
Open in desktop
16 changes: 12 additions & 4 deletions src/teamwork.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,19 @@ teamwork::pull_request_closed() {
local -r user=$(github::get_sender_user)
local -r pr_url=$(github::get_pr_url)
local -r pr_title=$(github::get_pr_title)
local -r pr_merged=$(github::get_pr_merged)
Comment thread
toffentoffen marked this conversation as resolved.

teamwork::add_comment "
**$user** merged a PR: **$pr_title**
[$pr_url]($pr_url)
"
if [ "$pr_merged" == "true" ]; then
teamwork::add_comment "
**$user** merged a PR: **$pr_title**
[$pr_url]($pr_url)
"
else
teamwork::add_comment "
**$user** closed a PR without merging: **$pr_title**
[$pr_url]($pr_url)
"
fi
}

teamwork::pull_request_review_submitted() {
Expand Down
18 changes: 18 additions & 0 deletions tests/events/pull_request_closed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"action": "closed",
"number": 1,
"pull_request": {
"body": "This is the body of the PR. https://xxxx.teamwork.com/#/tasks/123 https://xxx.teamwork.com/#/tasks/456",
"head": {
"repo": {
"full_name": "teamwork/github-sync"
}
},
"html_url": "https://github.com/teamwork/github-sync/pull/1",
"title": "This is an example of a title for the PR.",
"merged": false
},
"sender": {
"login": "username"
}
}
4 changes: 2 additions & 2 deletions tests/events/pull_request_merged.json
View file
Open in desktop