{{ message }}
Only restart extension pipeline when capture area/bounds actually change - #37
Merged
walshie4 merged 1 commit intoAug 4, 2026
Conversation
ConfigurationUpdate was unconditionally Stop()/Start()-ing the active driver/grabber/processors on every settings change, including brightness. Since the Brightness slider fires Scroll events rapidly while dragging, this caused a Stop/Start storm that crashed the app. Position and bound values are now cached and compared so the restart only happens when the capture area actually moved; everything else (brightness, bias, weighting, step sleep, capture throttle) still applies live as before.
walshie4
approved these changes
Aug 4, 2026
krzys167-crypto
approved these changes
Aug 26, 2026
krzys167-crypto
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigurationUpdate was unconditionally Stop()/Start()-ing the active driver/grabber/processors on every settings change, including brightness. Since the Brightness slider fires Scroll events rapidly while dragging, this caused a Stop/Start storm that crashed the app. Position and bound values are now cached and compared so the restart only happens when the capture area actually moved; everything else (brightness, bias, weighting, step sleep, capture throttle) still applies live as before.
Testing: Reproduced the original crash on a real device by dragging the Brightness slider, which used to crash the app after a few drags. After this fix it no longer crashes, even when dragging quickly. Also checked that moving or resizing the capture region still restarts the driver correctly, so that behavior wasn't accidentally broken.