{{ message }}
Fix HslColor.A setter clamping to always be 0 - #36
Merged
Conversation
Math.Min and Math.Max arguments were swapped, so any assigned value was clamped to 0 regardless of input. Now clamps to the valid 0-255 range, matching the pattern used by the H/L/S setters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Math.Min and Math.Max arguments were swapped, so any assigned value was clamped to 0 regardless of input. Now clamps to the valid 0-255 range, matching the pattern used by the H/L/S setters.
Testing: This bug isn't actually reachable anywhere in the app, since nothing sets the Alpha value through this property. I confirmed the fix works by using a small separate test program, checking that values now clamp properly between 0 and 255 rather than always coming out as 0.