{{ message }}
Fix ColorClock.Stop() to report timeout failure - #35
Merged
walshie4 merged 1 commit intoAug 4, 2026
Conversation
Stop() always returned true even when the background driver task failed to complete within the wait timeout, unlike every other driver (ExampleGlowDriver, HSVFade, SinFade, NeonFade), which return false in that case so callers know the stop didn't succeed and the task wasn't disposed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop() always returned true even when the background driver task failed to complete within the wait timeout, unlike every other driver (ExampleGlowDriver, HSVFade, SinFade, NeonFade), which return false in that case so callers know the stop didn't succeed and the task wasn't disposed.
Testing: ColorClock isn't reachable from the app's UI, so there was no way to test it by clicking around. Instead I wrote a small separate test program that runs ColorClock directly, starts it, then stops it before it's actually ready to finish. Before the fix, Stop() always reported success even when it hadn't actually stopped. Now it correctly reports failure in that case, and still reports success for a normal stop.