{{ message }}
Fix PreOutputProcessor color-output bugs - #34
Merged
walshie4 merged 2 commits intoAug 4, 2026
Conversation
- Add missing return after announcing Black for low-brightness colors, which was causing the real (dim) color to be announced again right after, double-firing the color-changed event. - Fix operator precedence in avgBias calculation: parenthesize the sum before dividing by 3, so red/green bias are averaged along with blue instead of being added in full. - Route the low-brightness Black target through the same weighted- averaging step as any other color instead of returning early before it. The early return fixed the double-fire but also skipped smoothing for every transition into darkness, causing an abrupt hard cut to black instead of a smooth fade whenever the sampled brightness dropped below the cutoff.
xDeeKay
force-pushed
the
fix/preoutputprocessor-color-bugs
branch
from
July 30, 2026 14:34
23572e8 to
b17175e
Compare
The cdbc29b fix made the black-cutoff branch fall through to weighted averaging so in-capture transitions stay smooth, but that same branch is used by every power-off route (quit, power toggle, sleep/lock, session logoff). With weighting enabled, the off command's black got blended with the last on-screen color instead of sent as-is, and since it's the final color before disconnect the device stayed lit. Set manualMode before sending PowerOffCommand, same as other immediate-color overrides, to bypass weighting for these.
walshie4
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Testing: Tested with a real Antumbra Glow device connected. Before the fix, dropping to a dark color would flash black and then immediately show the real dim color right after. That double flash is gone now. Also checked the white balance sliders, and the color shift they produce looks correctly balanced instead of leaning too far toward red and green.